Skip to content

Commit 1044768

Browse files
authored
chore: skip logging for streaming rest RPCs (#2280)
1 parent 233dc9c commit 1044768

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,8 @@ class {{service.name}}RestTransport(_Base{{ service.name }}RestTransport):
256256
{% endif %}{# method.lro #}
257257
{#- TODO(https://github.com/googleapis/gapic-generator-python/issues/2274): Add debug log before intercepting a request #}
258258
resp = self._interceptor.post_{{ method.name|snake_case }}(resp)
259+
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2279): Add logging support for rest streaming. #}
260+
{% if not method.server_streaming %}
259261
if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(logging.DEBUG): # pragma: NO COVER
260262
http_response = {
261263
"payload": {% if method.output.ident.is_proto_plus_type %}{{ method.output.ident }}.to_json(resp){% else %}json_format.MessageToJson(resp){% endif %},
@@ -272,6 +274,7 @@ class {{service.name}}RestTransport(_Base{{ service.name }}RestTransport):
272274
"httpResponse": http_response,
273275
},
274276
)
277+
{% endif %}{# if not method.server_streaming #}
275278
return resp
276279

277280
{% endif %}{# method.void #}

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest_asyncio.py.j2

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,8 @@ class Async{{service.name}}RestTransport(_Base{{ service.name }}RestTransport):
217217
json_format.Parse(content, pb_resp, ignore_unknown_fields=True)
218218
{% endif %}{# if method.server_streaming #}
219219
resp = await self._interceptor.post_{{ method.name|snake_case }}(resp)
220+
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2279): Add logging support for rest streaming. #}
221+
{% if not method.server_streaming %}
220222
if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(logging.DEBUG): # pragma: NO COVER
221223
http_response = {
222224
"payload": {% if method.output.ident.is_proto_plus_type %}{{ method.output.ident }}.to_json(response){% else %}json_format.MessageToJson(response){% endif %},
@@ -232,7 +234,8 @@ class Async{{service.name}}RestTransport(_Base{{ service.name }}RestTransport):
232234
"httpResponse": http_response,
233235
},
234236
)
235-
237+
238+
{% endif %}{# if not method.server_streaming #}
236239
return resp
237240

238241
{% endif %}{# method.void #}

0 commit comments

Comments
 (0)