Skip to content

Commit d74e8f2

Browse files
committed
Merge pull request #873 from tseaver/825-storage-remove_blob_connection
Remove 'Blob.connection' property.
2 parents 290b09e + e1f1db1 commit d74e8f2

File tree

3 files changed

+0
-14
lines changed

3 files changed

+0
-14
lines changed

gcloud/storage/blob.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -132,16 +132,6 @@ def __repr__(self):
132132

133133
return '<Blob: %s, %s>' % (bucket_name, self.name)
134134

135-
@property
136-
def connection(self):
137-
"""Getter property for the connection to use with this Blob.
138-
139-
:rtype: :class:`gcloud.storage.connection.Connection` or None
140-
:returns: The connection to use, or None if no connection is set.
141-
"""
142-
if self.bucket and self.bucket.connection:
143-
return self.bucket.connection
144-
145135
@property
146136
def path(self):
147137
"""Getter property for the URL path to this Blob.

gcloud/storage/test_blob.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ def mock_get_bucket():
4040
blob = self._makeOne(None)
4141

4242
self.assertEqual(blob.bucket, FAKE_BUCKET)
43-
self.assertEqual(blob.connection, None)
4443
self.assertEqual(blob.name, None)
4544
self.assertEqual(blob._properties, {})
4645
self.assertFalse(blob._acl.loaded)
@@ -50,7 +49,6 @@ def test_ctor_defaults(self):
5049
FAKE_BUCKET = _Bucket(None)
5150
blob = self._makeOne(None, bucket=FAKE_BUCKET)
5251
self.assertEqual(blob.bucket, FAKE_BUCKET)
53-
self.assertEqual(blob.connection, None)
5452
self.assertEqual(blob.name, None)
5553
self.assertEqual(blob._properties, {})
5654
self.assertFalse(blob._acl.loaded)
@@ -63,7 +61,6 @@ def test_ctor_explicit(self):
6361
properties = {'key': 'value'}
6462
blob = self._makeOne(BLOB_NAME, bucket=bucket, properties=properties)
6563
self.assertTrue(blob.bucket is bucket)
66-
self.assertTrue(blob.connection is connection)
6764
self.assertEqual(blob.name, BLOB_NAME)
6865
self.assertEqual(blob._properties, properties)
6966
self.assertFalse(blob._acl.loaded)

gcloud/storage/test_bucket.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ def test_get_items_from_response_non_empty(self):
7373
self.assertEqual(len(blobs), 1)
7474
blob = blobs[0]
7575
self.assertTrue(isinstance(blob, Blob))
76-
self.assertTrue(blob.connection is connection)
7776
self.assertEqual(blob.name, BLOB_NAME)
7877
self.assertEqual(iterator.prefixes, ('foo',))
7978

0 commit comments

Comments
 (0)