Add CSM for batch write flow control #2685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
kongweihan
force-pushed
the
csm-batch-write-flow-control
branch
2 times, most recently
from
2ca884e to
b4006a2
Compare
mutianf
reviewed
Oct 6, 2025
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracer.java
Outdated
Show resolved
Hide resolved
...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracer.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Outdated
Show resolved
Hide resolved
kongweihan
force-pushed
the
csm-batch-write-flow-control
branch
from
b4006a2 to
e8a246f
Compare
mutianf
reviewed
Oct 8, 2025
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracer.java
Show resolved
Hide resolved
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Show resolved
Hide resolved
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
kongweihan
force-pushed
the
csm-batch-write-flow-control
branch
from
e8a246f to
ae0ed5a
Compare
kongweihan
force-pushed
the
csm-batch-write-flow-control
branch
7 times, most recently
from
7d3fdd2 to
5f07efc
Compare
product-auto-label
bot
added
size: l
mutianf
reviewed
Dec 10, 2025
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| builder.addEntriesBuilder().setIndex(i); | ||
|
|
||
| com.google.protobuf.Duration duration = builder.getRateLimitInfoBuilder().getPeriodBuilder().setSeconds(10).build(); |
Contributor
There was a problem hiding this comment.
nit: can you import com.google.bigtable.v2.RateLimitInfo so we don't need to write the full path here?
Contributor
Author
There was a problem hiding this comment.
You meant Duration? I didn't see a full path here for RateLimitInfo?
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Show resolved
Hide resolved
kongweihan
force-pushed
the
csm-batch-write-flow-control
branch
3 times, most recently
from
8e84e9f to
7981240
Compare
mutianf
reviewed
Dec 12, 2025
Contributor
mutianf
left a comment
mutianf
left a comment
There was a problem hiding this comment.
Thank you for adding the tests, left some more nits but otherwise looks good!
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/RateLimitingServerStreamingCallable.java
Show resolved
Hide resolved
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java
Show resolved
Hide resolved
...le/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTestUtils.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
| batcher.add( | ||
| RowMutationEntry.create("batch-write-flow-control-success-08").setCell("f", "q", "v")); | ||
|
|
||
| // closing the batcher to trigger the third flush |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| // closing the batcher to trigger the third flush | |
| // closing the batcher to trigger the flush |
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
| batcher.add( | ||
| RowMutationEntry.create("batch-write-flow-control-success-05").setCell("f", "q", "v")); | ||
|
|
||
| // closing the batcher to trigger the third flush |
Contributor
There was a problem hiding this comment.
Suggested change
| // closing the batcher to trigger the third flush | |
| // closing the batcher to trigger the flush |
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Outdated
Show resolved
Hide resolved
kongweihan
force-pushed
the
csm-batch-write-flow-control
branch
from
7981240 to
caf5a50
Compare
mutianf
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.