fix: update appendable upload retry logic to be able to more gracefully handle slow uploads #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly handle slow uploads Prior to this change, the retry context for an appendable upload would start its retry timeout clock at stream opening time, if an upload is proceeding slowly and a retryable error is delivered the retry might not retry even if there had been previous successful incremental response messages more recently. This change updates the logic to reset the retry timeout clock each time a successful response message is received. This maps logically to what is done with resumable uploads today where the timer is live for each PUT.
product-auto-label
bot
added
size: m
ddelgrosso1
approved these changes
Dec 15, 2025
ShreyasSinha
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the retry context for an appendable upload would start its retry timeout clock at stream opening time, if an upload is proceeding slowly and a retryable error is delivered the retry might not retry even if there had been previous successful incremental response messages more recently.
This change updates the logic to reset the retry timeout clock each time a successful response message is received. This maps logically to what is done with resumable uploads today where the timer is live for each PUT.