feat: implement Approximate Nearest Neighbor support for DDL (CREATE TABLE, CREATE VECTOR INDEX)#124
Merged
gauravpurohit06 merged 16 commits intoFeb 4, 2025
Conversation
product-auto-label
Bot
added
the
api: spanner
odeke-em
changed the title
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
2 times, most recently
from
dfeab0a to
2ef461a
Compare
odeke-em
changed the title
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
3 times, most recently
from
36c552c to
64358ab
Compare
odeke-em
changed the title
gauravpurohit06
suggested changes
Jan 20, 2025
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
from
7e5279a to
44d0996
Compare
Contributor
|
/gcbrun |
gauravpurohit06
suggested changes
Jan 27, 2025
Contributor
gauravpurohit06
left a comment
gauravpurohit06
left a comment
There was a problem hiding this comment.
Added two more comments, based on it... you also need to update function signature throughout the file not mentioning it explicitly.
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
3 times, most recently
from
a791690 to
8ea75e1
Compare
This change introduces new nox directives: * blacken: `nox -s blacken` * format: `nox -s format` to apply formatting to files * lint: `nox -s lint` to flag linting issues * unit: to run unit tests locally which are the basis to enable scalable development and continuous testing as I prepare to bring in Approximate Nearest Neighors (ANN) functionality into this package. Also while here, fixed a typo in the README.rst file that didn't have the correct import path.
This change adds ANN distance strategies for GoogleSQL semantics. While here started unit tests to effectively test out components without having to have a running Cloud Spanner instance. Updates googleapis#94
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
2 times, most recently
from
bc0b254 to
d654428
Compare
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
from
d654428 to
430d14d
Compare
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
from
0f2cd8e to
8be267d
Compare
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
from
b8948a3 to
66930b4
Compare
gauravpurohit06
suggested changes
Feb 3, 2025
Contributor
gauravpurohit06
left a comment
gauravpurohit06
left a comment
There was a problem hiding this comment.
@odeke-em, Other than granular comments there are inconsistencies in return type here through the implementation and also use of None keyword. Please correct it.
Contributor
|
/gcbrun |
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
2 times, most recently
from
90220f1 to
5b8cfd3
Compare
odeke-em
force-pushed
the
ANN-support-update-distance_strategies
branch
from
5b8cfd3 to
130bc46
Compare
gauravpurohit06
suggested changes
Feb 3, 2025
Contributor
gauravpurohit06
left a comment
gauravpurohit06
left a comment
There was a problem hiding this comment.
in public apis... decide whether to use knn vs ann... Mention it explicitly what to do.
Contributor
Author
|
@gauravpurohit06 I humbly and highly recommend that we get this PR in as is, then I can send more given firstly how massive it is, I actually had to delete code out of other helpers to keep in manageable, plus your time constraint. Getting 90% in before you are out of the office goes a much longer way than our 5+ week long PR. Sending smaller PRs for the other parts is planned as I mentioned a couple of times offline and allows for much more effective testing too. |
Contributor
|
/gcbrun |
Contributor
Author
|
@gauravpurohit06 kindly help me run gcbrun. |
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds ANN distance strategies for GoogleSQL semantics.
While here started unit tests to effectively test out components
without having to have a running Cloud Spanner instance.
Implements Data Definition Language (DDL) functionality for:
Updates #94