feat: graph_name validation on graph store construction#162
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
Bot
added
the
api: spanner
|
Its to raise error in graph store construction (rather than add_graph_document method) if user has used "-" in graph name or any other invalid graphname @rahul2393 could you look into it? |
Contributor
|
lgtm, can you add a test for it? |
RedHeadphone
changed the title
Contributor
Author
|
@mtyin added tests |
Contributor
|
/gcbrun |
Contributor
|
lgtm. Make sure the tests are passing. |
amullick-git
approved these changes
Apr 4, 2025
Contributor
Author
|
@averikitsch pending review |
Collaborator
|
/gcbrun |
averikitsch
changed the title
averikitsch
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding small validation in graph name