Typings are messed up

[ItalyPaleAle]

When importing version 2.0.3, TypeScript types are completely messed up:

1. It's impossible to use Promises as returned methods. Taking one method as example: exists(options: any, callback?: any): void;. The documentation says that it can be used with Promises too (and it works), but the type definition shows return type as void.
2. Types are just wrong. In the same method, the JSDoc definition says that the first argument (options) is optional, but the method signature marks it mandatory.
3. The library uses any as type anywhere. Options dictionaries, callbacks, etc: these are things that should be explicitly typed.
4. The library still uses JSDoc types everywhere, which should be migrated to TypeScript definitions.

[sabrehagen]

Add getFiles to the list. The signature is getFiles(query: GetFilesRequest, callback?: any): void; but the function returns a promise.

[ItalyPaleAle]

Almost all methods have wrong typings. I showed one just as example.

When will the fix be released? I have a project due in a few days and pretty much everything is written in typescript. Is the only solution reverting back to an older version? Or is there another workaround?

[mattwelke]

@mg131 If it's urgent, you can revert back to using the community-driven @types package.

@Welkie Thanks. Will do

[rraina]

@Welkie -- How do you override the default index.d.ts provided by the package (other than migrating to 1.7.0)? Also, do you have an ETA on when the types will be fixed?

[mattwelke]

@rraina Google appears to have disabled the built in types with recent versions of this package until they resolve the issues with them. Therefore, to override them, you'd just opt to use the latest version of of this package with the latest version of the @types package as well. Because I'm not affiliated with Google, I don't know when the issues will be resolved. I'm merely keeping track of their TypeScript efforts so I can reduce the number of dependencies my Node projects have.

[rraina]

Thanks Matt. I tried downloading 2.0.3 (the latest package on NPM at time of this writing) and the @types/google-cloud__storage": "^1.7.2”. However, the 2.0.3 package has a conflicting index.d.ts :/. Let me know if I am doing something wrong. On Sep 21, 2018, at 1:19 PM, Matt Welke <notifications@github.com<mailto:notifications@github.com>> wrote: @rraina<https://github.com/rraina> Google appears to have disabled the built in types with recent versions of this package until they resolve the issues with them. Therefore, to override them, you'd just opt to use the latest version of of this package with the latest version of the @types<https://github.com/types> package as well. Because I'm not affiliated with Google, I don't know when the issues will be resolved. I'm merely keeping track of their TypeScript efforts so I can reduce the number of dependencies my Node projects have. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#384 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABfM1JmtMAH1z8gizO_GqXiZ4Efi3Urzks5udUnfgaJpZM4WkfGP>.