Revert "fix: unit test for graphene pr#1412"#1350
Closed
firaskafri wants to merge 1 commit into
Closed
Conversation
This reverts commit 5d81ba0.
erikwrede
reviewed
Sep 24, 2022
erikwrede
left a comment
erikwrede
left a comment
Member
There was a problem hiding this comment.
Wouldn't it be more elegant to push a fix to setup.py instead of reverting the entire PR and reopening it without the changes to setup.py?
Collaborator
Author
@erikwrede Thank you! |
firaskafri
deleted the
revert-1315-users/tcleonard/fix-test-for-graphene-PR#1412
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1315 due changes in setup.py that probably broke tests