Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gravitydepartment/modal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0
Choose a base ref
...
head repository: gravitydepartment/modal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 15 commits
  • 4 files changed
  • 1 contributor

Commits on Feb 19, 2019

  1. Add “$modal-close-icon-svg” variable to SCSS

    @brendanfalkowski
    brendanfalkowski committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    1cd3433 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. #4: close existing modals before creating a new modal

    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    9daf779 View commit details
    Browse the repository at this point in the history

  2. Restore focus immediately on close (not waiting for close animations … 

    …to finish)
    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    925ac23 View commit details
    Browse the repository at this point in the history

  3. Remove value from “data-modal-close” attribute

    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    4b22ecd View commit details
    Browse the repository at this point in the history

  4. Remove event listener for click on “.modal_backdrop” 

    Use existing event listener for “data-modal-close” attribute
    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    e8ba8ba View commit details
    Browse the repository at this point in the history

  5. Add margin-bottom to “.modal_dialog” 

    When the dialog is taller than the viewport and extends past the bottom of the window this provides spacing
    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    e9dacc1 View commit details
    Browse the repository at this point in the history

  6. Update README to use delegated event listener to trigger modals

    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    c127edd View commit details
    Browse the repository at this point in the history

  7. Fix bug in README

    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    6b83405 View commit details
    Browse the repository at this point in the history

  8. Indentation

    @brendanfalkowski
    brendanfalkowski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    d5c651d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Standardize DocBlock

    @brendanfalkowski
    brendanfalkowski committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    bb39aff View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Fix logo in README

    @brendanfalkowski
    brendanfalkowski authored Apr 29, 2019
    Configuration menu
    Copy the full SHA
    9589c32 View commit details
    Browse the repository at this point in the history

  2. Use HTTPS in README

    @brendanfalkowski
    brendanfalkowski authored Apr 29, 2019
    Configuration menu
    Copy the full SHA
    907fa75 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Fix typo

    @brendanfalkowski
    brendanfalkowski committed May 16, 2019
    Configuration menu
    Copy the full SHA
    78178b3 View commit details
    Browse the repository at this point in the history

  2. Reduce font-size of “modal_header” title

    @brendanfalkowski
    brendanfalkowski committed May 16, 2019
    Configuration menu
    Copy the full SHA
    90aa3a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Polyfill Element.closest() so triggers with child elements work

    @brendanfalkowski
    brendanfalkowski committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    dac4049 View commit details
    Browse the repository at this point in the history
Loading