chore(deps): upgrade go-github from v84 to v88

Updates github.com/google/go-github from v84.0.0 to v88.0.0.

Breaking changes in v88:
- NewClient now returns (*Client, error) instead of *Client
- WithAuthToken and WithEnterpriseURLs are now ClientOptionsFunc
  parameters passed to NewClient, not methods on Client

Updates all 29 files to use the new API pattern.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: grokify

auth/app.go

@@ -11,7 +11,7 @@ import (
 	"time"
 
 	"github.com/golang-jwt/jwt/v5"
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 )
 
 // JWT constants for GitHub App authentication.
@@ -163,7 +163,10 @@ func NewAppClient(ctx context.Context, cfg *AppConfig) (*github.Client, error) {
 	}
 
 	// Create client with JWT auth to get installation token
-	jwtClient := github.NewClient(nil).WithAuthToken(token)
+	jwtClient, err := github.NewClient(github.WithAuthToken(token))
+	if err != nil {
+		return nil, fmt.Errorf("creating github client: %w", err)
+	}
 
 	// Get installation access token
 	installToken, _, err := jwtClient.Apps.CreateInstallationToken(ctx, cfg.InstallationID, nil)
@@ -172,7 +175,10 @@ func NewAppClient(ctx context.Context, cfg *AppConfig) (*github.Client, error) {
 	}
 
 	// Create client with installation token
-	client := github.NewClient(nil).WithAuthToken(installToken.GetToken())
+	client, err := github.NewClient(github.WithAuthToken(installToken.GetToken()))
+	if err != nil {
+		return nil, fmt.Errorf("creating github client: %w", err)
+	}
 
 	return client, nil
 }
@@ -220,7 +226,10 @@ func ListAppInstallations(ctx context.Context, cfg *AppConfig) ([]AppInstallatio
 		return nil, fmt.Errorf("creating JWT: %w", err)
 	}
 
-	client := github.NewClient(nil).WithAuthToken(token)
+	client, err := github.NewClient(github.WithAuthToken(token))
+	if err != nil {
+		return nil, fmt.Errorf("creating github client: %w", err)
+	}
 
 	installations, _, err := client.Apps.ListInstallations(ctx, nil)
 	if err != nil {

auth/auth.go

@@ -5,7 +5,7 @@ import (
 	"context"
 	"net/http"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 	"golang.org/x/oauth2"
 )
 
@@ -41,8 +41,8 @@ func NewTokenClient(ctx context.Context, token string) *http.Client {
 }
 
 // NewGitHubClient creates a GitHub client authenticated with the given token.
-func NewGitHubClient(ctx context.Context, token string) *github.Client {
-	return github.NewClient(NewTokenClient(ctx, token))
+func NewGitHubClient(ctx context.Context, token string) (*github.Client, error) {
+	return github.NewClient(github.WithHTTPClient(NewTokenClient(ctx, token)))
 }
 
 // GetAuthenticatedUser returns the authenticated user's login.

checks/checks.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 )
 
 // ListCheckRuns lists check runs for a commit SHA or branch.

checks/checks_test.go

@@ -3,7 +3,7 @@ package checks
 import (
 	"testing"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 )
 
 func ptr[T any](v T) *T {

cmd/gogithub/cmd_profile.go

@@ -10,7 +10,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 	"github.com/grokify/mogo/fmt/progress"
 	"github.com/spf13/cobra"
 
@@ -257,7 +257,10 @@ func runProfileFromAPI() error {
 	ctx := context.Background()
 
 	// Create clients
-	restClient := github.NewClient(nil).WithAuthToken(token)
+	restClient, err := github.NewClient(github.WithAuthToken(token))
+	if err != nil {
+		return fmt.Errorf("creating github client: %w", err)
+	}
 	gqlClient := graphql.NewClient(ctx, token)
 
 	fmt.Fprintf(os.Stderr, "Fetching profile for '%s' from %s to %s\n\n",

cmd/gogithub/cmd_search_prs.go

@@ -6,7 +6,7 @@ import (
 	"os"
 	"strings"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 	"github.com/grokify/gogithub/search"
 	"github.com/spf13/cobra"
 )
@@ -47,7 +47,11 @@ func runSearchPRs(cmd *cobra.Command, args []string) error {
 	}
 
 	// Create unauthenticated client for public data
-	c := search.NewClient(github.NewClient(nil))
+	ghClient, err := github.NewClient()
+	if err != nil {
+		return fmt.Errorf("creating github client: %w", err)
+	}
+	c := search.NewClient(ghClient)
 
 	ii := search.Issues{}
 

cmd/searchuserpr/main.go

@@ -7,7 +7,7 @@ import (
 	"os"
 	"strings"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 	"github.com/grokify/gogithub/search"
 	"github.com/grokify/mogo/log/logutil"
 	flags "github.com/jessevdk/go-flags"
@@ -35,7 +35,11 @@ func main() {
 		os.Exit(0)
 	}
 
-	c := search.NewClient(github.NewClient(nil))
+	ghClient, err := github.NewClient()
+	if err != nil {
+		log.Fatal(err)
+	}
+	c := search.NewClient(ghClient)
 
 	ii := search.Issues{}
 

config/config.go

@@ -6,7 +6,7 @@ import (
 	"errors"
 	"os"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 	"golang.org/x/oauth2"
 )
 
@@ -244,11 +244,12 @@ func (c *Config) NewClient(ctx context.Context) (*github.Client, error) {
 	)
 	tc := oauth2.NewClient(ctx, ts)
 
+	opts := []github.ClientOptionsFunc{github.WithHTTPClient(tc)}
 	if c.IsEnterprise() {
-		return github.NewClient(tc).WithEnterpriseURLs(c.BaseURL, c.UploadURL)
+		opts = append(opts, github.WithEnterpriseURLs(c.BaseURL, c.UploadURL))
 	}
 
-	return github.NewClient(tc), nil
+	return github.NewClient(opts...)
 }
 
 // MustNewClient creates a GitHub client from the configuration.

errors/errors.go

@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"net/http"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 )
 
 // Standard errors for GitHub operations.

errors/errors_test.go

@@ -5,7 +5,7 @@ import (
 	"net/http"
 	"testing"
 
-	"github.com/google/go-github/v84/github"
+	"github.com/google/go-github/v88/github"
 )
 
 func TestTranslateNotFound(t *testing.T) {