revert local copy in updateLocalityID

Author: purnesh42H

xds/internal/balancer/clusterimpl/clusterimpl.go

@@ -418,13 +418,7 @@ type scWrapper struct {
 }
 
 func (scw *scWrapper) updateLocalityID(lID clients.Locality) {
-	// Store a pointer to a new, heap-allocated clients.Locality because the
-	// pointer (scw.locality) is stored in an atomic.Pointer, and must remain
-	// valid for concurrent access by other goroutines even after this function
-	// returns.
-	l := new(clients.Locality)
-	*l = lID
-	scw.locality.Store(l)
+	scw.locality.Store(&lID)
 }
 
 func (scw *scWrapper) localityID() clients.Locality {

xds/internal/clients/grpctransport/grpc_transport_test.go

@@ -359,7 +359,7 @@ func (s) TestNewStream_Error(t *testing.T) {
 // request on the server is same as sent. It then wait to receive a
 // testDiscoverResponse from the server and verifies that the received
 // discovery response is same as sent from the server.
-func (s) TestStream_SendAndRecv(t *testing.T) {
+func TestStream_SendAndRecv(t *testing.T) {
 	ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout)
 	defer cancel()