Skip to content

Commit 9f98c16

Browse files
committed
Fix release script
We have to pin Grunt to 1.5.3, since this is the latest version to support Node 10, which is needed for the release process. Also improved the Dockerfile and added a warning related to "yo release".
1 parent 45443b4 commit 9f98c16

File tree

3 files changed

+118
-166
lines changed

3 files changed

+118
-166
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,11 @@ A full release via Docker may be completed with the following:
132132

133133
# Generate config for yo generator-release:
134134
# https://github.com/kpdecker/generator-release#example
135-
# You have to add a valid GitHub OAuth token!
136-
RUN echo "module.exports = {\n auth: 'oauth',\n token: 'GitHub OAuth token'\n};" > /home/node/.config/generator-release
135+
# You have to add a valid GitHub access token! (Used for reading issues and pull requests.)
136+
RUN echo "module.exports = {\n auth: 'oauth',\n token: 'GitHub personal access token'\n};" > /home/node/.config/generator-release
137137
RUN chown -R node:node /home/node/.config
138+
RUN chown -R node:node /home/node/.ssh
139+
RUN chown -R node:node /home/node/tmp
138140

139141
# Add the generated key to GitHub: https://github.com/settings/keys
140142
RUN ssh-keygen -q -t ed25519 -N '' -f /home/node/.ssh/id_ed25519 -C "release@handlebarsjs.com"
@@ -155,9 +157,12 @@ A full release via Docker may be completed with the following:
155157
* Add GitHub API token: `vi /home/node/.config/generator-release`
156158
* Execute the following steps:
157159
```bash
158-
npm ci
160+
npm install
159161
npm install -g yo@1 grunt@1 generator-release
160162
npm run release
163+
# Warning! This step will collect data from GitHub, bump the version,
164+
# create a new commit, create a new tag and push it to GitHub.
165+
# https://github.com/kpdecker/generator-release?tab=readme-ov-file#usage
161166
yo release
162167
npm login
163168
npm publish

0 commit comments

Comments
 (0)