Merge pull request #525 from harehare/fix/module-validation-and-error-handling

🐛 fix(hir): improve module validation and error handling

Author: harehare

crates/mq-hir/src/error.rs

@@ -16,6 +16,11 @@ pub enum HirError {
         symbol: Symbol,
         similar_name: Option<Vec<CompactString>>,
     },
+    #[error("Included module not found: {module_name}")]
+    ModuleNotFound {
+        symbol: Symbol,
+        module_name: CompactString,
+    },
 }
 
 impl Hir {
@@ -24,14 +29,28 @@ impl Hir {
             .iter()
             .filter_map(|(symbol_id, symbol)| match symbol.kind {
                 SymbolKind::Call | SymbolKind::Ref => {
-                    if !self.references.contains_key(&symbol_id) {
+                    if self.references.contains_key(&symbol_id) {
+                        None
+                    } else {
                         Some(HirError::UnresolvedSymbol {
                             symbol: symbol.clone(),
                             similar_name: self
                                 .find_similar_names(&symbol.clone().value.unwrap_or_default()),
                         })
-                    } else {
-                        None
+                    }
+                }
+                SymbolKind::Include(_) => {
+                    let module_name = symbol
+                        .clone()
+                        .value
+                        .unwrap_or(CompactString::new("unknown"))
+                        .clone();
+                    match self.module_loader.read_file(&module_name) {
+                        Ok(_) => None,
+                        Err(_) => Some(HirError::ModuleNotFound {
+                            symbol: symbol.clone(),
+                            module_name,
+                        }),
                     }
                 }
                 _ => None,
@@ -49,6 +68,9 @@ impl Hir {
                         HirError::UnresolvedSymbol { symbol, .. } => {
                             symbol.source.text_range.clone().unwrap_or_default()
                         }
+                        HirError::ModuleNotFound { symbol, .. } => {
+                            symbol.source.text_range.clone().unwrap_or_default()
+                        }
                     },
                 )
             })
@@ -118,6 +140,9 @@ mod tests {
                 assert_eq!(symbol.value.as_deref(), Some("unknown_var"));
                 assert!(similar_name.is_none());
             }
+            _ => {
+                panic!("Expected UnresolvedSymbol error");
+            }
         }
     }