Merge pull request #286 from mre/patch-1

jrasell · web-flow · commit 1af56e6260fa · 2019-07-10T09:14:58.000+02:00
Fix segfault when accessing dep, which is nil on error.
diff --git a/levant/deploy.go b/levant/deploy.go
@@ -177,7 +177,7 @@ func (l *levantDeployment) deploy() (success bool) {
 
 		dep, _, err := l.nomad.Deployments().Info(depID, nil)
 		if err != nil {
-			log.Error().Err(err).Msgf("levant/deploy: unable to query deployment %s for auto-revert check", dep.ID)
+			log.Error().Err(err).Msgf("levant/deploy: unable to query deployment %s for auto-revert check", depID)
 			return
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ func (l *levantDeployment) deploy() (success bool) {`
`177`	`177`
`178`	`178`	`dep, _, err := l.nomad.Deployments().Info(depID, nil)`
`179`	`179`	`if err != nil {`
`180`		`- log.Error().Err(err).Msgf("levant/deploy: unable to query deployment %s for auto-revert check", dep.ID)`
	`180`	`+ log.Error().Err(err).Msgf("levant/deploy: unable to query deployment %s for auto-revert check", depID)`
`181`	`181`	`return`
`182`	`182`	`}`
`183`	`183`