Merged
Conversation
paddycarver
force-pushed
the
paddy_types_primitives
branch
from
31969ca to
3749993
Compare
Contributor
Author
|
These tests rely on hashicorp/terraform-plugin-go#85, which fixes unmarshaling into uninstantiated *big.Floats. |
paddycarver
force-pushed
the
paddy_types_primitives
branch
from
6af9c11 to
ba037f3
Compare
kmoe
reviewed
Jun 1, 2021
kmoe
reviewed
Jun 1, 2021
|
|
||
| // testAttributeType is a dummy attribute type to compare against with Equal to | ||
| // make sure we can handle unexpected types being passed in. | ||
| type testAttributeType struct{} |
kmoe
approved these changes
Jun 1, 2021
Member
kmoe
left a comment
kmoe
left a comment
There was a problem hiding this comment.
delightful, especially the tests
This adds to #28 by creating implementations of the attr.Type interface for our primitive types: bools, numbers, and strings.
paddycarver
force-pushed
the
paddy_types_primitives
branch
from
99d63f3 to
cdc6765
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds to #28 by creating implementations of the attr.Type interface for our primitive types: bools, numbers, and strings.
This is likewise a split of code originally written for #11 that is being split out into its own PR for easier review. (Or, at least, review will be easier when #28 is merged, which should happen before this is merged.)