Add support for retrieving tfprotov6.ProviderServer.#72
Merged
paddycarver merged 1 commit intomainfrom Jul 22, 2021
Merged
Conversation
We need access to the tfprotov6.ProviderServer underlying `tfsdk.Serve` for things like testing and muxing. Add a function that will expose it.
paddycarver
force-pushed
the
paddy_proto6_server
branch
from
a30af09 to
eaf37c1
Compare
bflad
approved these changes
Jul 19, 2021
Contributor
bflad
left a comment
bflad
left a comment
There was a problem hiding this comment.
Looks good to me 🚀
Not sure if it's worth mentioning that this new function is typically used for testing and muxing purposes for future travelers or those going through the Go package documentation.
kmoe
approved these changes
Jul 22, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need access to the tfprotov6.ProviderServer underlying
tfsdk.Servefor things like testing and muxing. Add a function that will expose it.