tfsdk: Initial support for Attribute, Data Source, Provider, and Resource validation

[bflad]

Reference: #17
Reference: #65

[paddycarver]

Hot take: is Config necessary here, or can we save some typing by removing it?

[bflad]

I'm certainly amenable to updating the name, I'm just not sure if there's any concerns with keeping the names and types relatively close to the RPCs similar to as has been done elsewhere. Should there be any future other implementations with differing semantics, it could be weird to have DataSourceValidator vs DataSourceStateValidator for example.

[bflad]

I'm going to address the above comments and pull in the Attribute validation from #76 so it can all be reviewed together. 👍

[bflad]

This now includes the initial Schema and Attribute validation from #76 wired together with the Validate RPC calls. It needs a test fix from the testing changing on main and unit testing for the Schema and Attribute validation. I've run out of time for today, but it might be worth a cursory look to ensure it's going in the right direction.

[paddycarver]

Seems like it's on the right path to me.

[paddycarver]

LGTM, great work @bflad.

[kmoe]

Should this append instead, in case multiple attribute validators return warning diags?

[bflad]

Initially this was appending, but I was asked to switch it to "passthrough" diagnostics: #75 (comment)

Personally I think pre-populating a response, while offering overwrite capabilities easily, could be confusing for implementors to understand the semantics. We could offer prior diagnostics in the request with diagnostic modifications in the response to clarify things on both sides of these calls (or not allow diagnostic modification). Please let me know if you would like me to raise an issue regarding this.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.