Skip to content

Migrate schema package and internal/proto6 Schema/Attribute into tfsdk package#77

Merged
bflad merged 3 commits intomainfrom
td-schema-to-tfsdk
Jul 29, 2021
Merged

Migrate schema package and internal/proto6 Schema/Attribute into tfsdk package#77
bflad merged 3 commits intomainfrom
td-schema-to-tfsdk

Conversation

@bflad
Copy link
Contributor

@bflad bflad commented Jul 20, 2021

Reference: #76

bflad added 2 commits July 27, 2021 11:58
Reference: #76

This is now stuck at the below:

```
package github.com/hashicorp/terraform-plugin-framework/internal/proto6
        imports github.com/hashicorp/terraform-plugin-framework/tfsdk
        imports github.com/hashicorp/terraform-plugin-framework/internal/proto6: import cycle not allowed
```
@bflad bflad force-pushed the td-schema-to-tfsdk branch from 821911d to edbc38e Compare July 27, 2021 16:03
@bflad bflad changed the title [DO NOT MERGE] Migrate schema package into tfsdk package Migrate schema package and internal/proto6 Schema/Attribute into tfsdk package Jul 27, 2021
@bflad bflad marked this pull request as ready for review July 27, 2021 16:05
@bflad bflad requested a review from a team July 27, 2021 16:06
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be my preferred approach, honestly.

Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, works for me

@bflad bflad merged commit 795e4be into main Jul 29, 2021
@bflad bflad deleted the td-schema-to-tfsdk branch July 29, 2021 20:42
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants