azurerm_container_app_environment_certificate - fix empty password scenario and add test (#31335)

[BUG] * `azurerm_container_app_environment_certificate` - fix an issue that prevented creating the resource with an empty value for `certificate_password`

Author: sreallymatt

internal/services/containerapps/container_app_environment_certificate_resource.go

@@ -192,7 +192,7 @@ func (r ContainerAppEnvironmentCertificateResource) Create() sdk.ResourceFunc {
 				Tags:       tags.Expand(cert.Tags),
 			}
 
-			if cert.CertificateBlob != "" && cert.CertificatePassword != "" {
+			if cert.CertificateBlob != "" {
 				model.Properties.Password = pointer.To(cert.CertificatePassword)
 				model.Properties.Value = pointer.To(cert.CertificateBlob)
 			} else if len(cert.CertificateKeyVault) > 0 {

internal/services/containerapps/container_app_environment_certificate_resource_test.go

@@ -34,6 +34,21 @@ func TestAccContainerAppEnvironmentCertificate_basic(t *testing.T) {
 	})
 }
 
+func TestAccContainerAppEnvironmentCertificate_basicEmptyPassword(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_container_app_environment_certificate", "test")
+	r := ContainerAppEnvironmentCertificateResource{}
+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.basicEmptyPassword(data),
+			Check: acceptance.ComposeTestCheckFunc(
+				check.That(data.ResourceName).ExistsInAzure(r),
+			),
+		},
+		data.ImportStep("certificate_blob_base64", "certificate_password"),
+	})
+}
+
 func TestAccContainerAppEnvironmentCertificate_basicUpdateTags(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_container_app_environment_certificate", "test")
 	r := ContainerAppEnvironmentCertificateResource{}
@@ -119,6 +134,23 @@ resource "azurerm_container_app_environment_certificate" "test" {
 `, r.template(data), data.RandomInteger)
 }
 
+func (r ContainerAppEnvironmentCertificateResource) basicEmptyPassword(data acceptance.TestData) string {
+	return fmt.Sprintf(`
+provider "azurerm" {
+  features {}
+}
+
+%[1]s
+
+resource "azurerm_container_app_environment_certificate" "test" {
+  name                         = "acctest-cacert%[2]d"
+  container_app_environment_id = azurerm_container_app_environment.test.id
+  certificate_blob_base64      = filebase64("testdata/testacc_nopassword.pfx")
+  certificate_password         = ""
+}
+`, r.template(data), data.RandomInteger)
+}
+
 func (r ContainerAppEnvironmentCertificateResource) basicAddTags(data acceptance.TestData) string {
 	return fmt.Sprintf(`
 provider "azurerm" {