Storage: Protect storageAccountsCache by lock in AccountKey() (#31323)

magodo · web-flow · commit 7f31df32c06d · 2025-12-10T16:12:59.000+01:00
[BUGFIX] * `azurerm_storage_account` fix a panic in client caching
diff --git a/internal/services/storage/client/helpers.go b/internal/services/storage/client/helpers.go
@@ -94,7 +94,9 @@ func (ad *AccountDetails) AccountKey(ctx context.Context, client Client) (*strin
 	}
 
 	// force-cache this
+	cacheAccountsLock.Lock()
 	storageAccountsCache[ad.StorageAccountId.StorageAccountName] = *ad
+	cacheAccountsLock.Unlock()
 
 	return ad.accountKey, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,9 @@ func (ad AccountDetails) AccountKey(ctx context.Context, client Client) (strin`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`// force-cache this`
	`97`	`+ cacheAccountsLock.Lock()`
`97`	`98`	`storageAccountsCache[ad.StorageAccountId.StorageAccountName] = *ad`
	`99`	`+ cacheAccountsLock.Unlock()`
`98`	`100`
`99`	`101`	`return ad.accountKey, nil`
`100`	`102`	`}`