New Resource: azurerm_arc_machine#26647
Merged
katbyte merged 7 commits intohashicorp:mainfrom Sep 13, 2024
Merged
Conversation
ms-zhenhua
suggested changes
Jul 25, 2024
Collaborator
ms-zhenhua
left a comment
There was a problem hiding this comment.
@neil-yechenwei, Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
Contributor
Author
|
@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. |
ms-zhenhua
approved these changes
Jul 30, 2024
Collaborator
|
@neil-yechenwei, thank you for your updates. LGTM~ |
|
@katbyte |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This is the PR to support Hybrid Compute Machine.
Given HC suggests to use arc_* for this PR, so I named it to azurerm_arc_machine.
API Spec: https://github.com/Azure/azure-rest-api-specs/blob/1ad29756bd141a47cac770140105a706d065ae1b/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2024-07-10/HybridCompute.json#L352
Overview doc: https://learn.microsoft.com/en-us/azure/azure-arc/system-center-virtual-machine-manager/overview
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_arc_machineThis is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.