mssql_managed_instance - upgrade to 2023-08-01-preview and hashicorp/go-azure-sdk

[catriona-m]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR updates the mssql_managed_instance to 2023-08-01-preview. It also updates it to use hashicorp/go-azure-sdk which is using the new base layer.

To workaround the property name change from StorageAccountType to RequestedBackupStorageRedundancy and the change in value names, this pr takes the old value names and maps them to the new names to avoid a breaking change.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
  Tests running in TC

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

mssql_managed_instance - upgrade to 2023-08-01-preview and hashicorp/go-azure-sdk [GH-26872]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Thanks @catriona-m - Just a few comments below (sorry if some are already outdated, I started the review before you pushed some changes)

[jackofallops]

We should probably actually nil and length-check this here to avoid crashes in future? While it's fine in create, the update path could potentially have a change where the length is 0. (The API might actually prevent this today, but we should be defensive against crashes that may be introduced in future)

[jackofallops]

Thanks for the changes @catriona-m - LGTM 👍

[stephybun]

Thanks @catriona-m and @jackofallops LGTM 🌶️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.