New Resource: `azurerm_data_protection_backup_policy_mysql_flexible_server` by neil-yechenwei · Pull Request #26955 · hashicorp/terraform-provider-azurerm

neil-yechenwei · 2024-08-07T04:31:07Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support Data Protection Backup Policy for MySQL FS.

API Reference: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2024-04-01

Overview: https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-backup-restore#long-term-retention-preview

Note: This PR is referring the existing Backup Instances/Backup Policies in RP https://github.com/hashicorp/terraform-provider-azurerm/tree/main/internal/services/dataprotection.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccDataProtectionBackupPolicyMySQLFlexibleServer_basic (282.39s)
--- PASS: TestAccDataProtectionBackupPolicyMySQLFlexibleServer_requiresImport (268.95s)
--- PASS: TestAccDataProtectionBackupPolicyMySQLFlexibleServer_complete (217.73s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_data_protection_backup_policy_mysql_flexible_server

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…rver

ms-zhenhua

Hi @neil-yechenwei ,

Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

...rnal/services/dataprotection/data_protection_backup_policy_mysql_flexible_server_resource.go

neil-yechenwei · 2024-08-08T01:52:21Z

@ms-zhenhua , thanks for the comments. I updated PR and left suggestions. Please take another look. Below is the latest test result I just now triggered.

ms-zhenhua · 2024-08-09T02:53:35Z

@neil-yechenwei, thank you for the update. LGTM~

...rnal/services/dataprotection/data_protection_backup_policy_mysql_flexible_server_resource.go

katbyte · 2024-09-13T00:53:15Z

...rnal/services/dataprotection/data_protection_backup_policy_mysql_flexible_server_resource.go

+			Type:         pluginsdk.TypeString,
+			Optional:     true,
+			ForceNew:     true,
+			ValidateFunc: validation.StringIsNotEmpty,


can we validate this?

The validation is added per the existing validation.

katbyte · 2024-09-13T00:53:30Z

...rnal/services/dataprotection/data_protection_backup_policy_mysql_flexible_server_resource.go

+			MinItems: 1,
+			Elem: &pluginsdk.Schema{
+				Type:         pluginsdk.TypeString,
+				ValidateFunc: validation.StringIsNotEmpty,


this should be validated as an ISO duration?

It's not a standard ISO duration. This is the sample "R/2021-05-23T02:30:00+00:00/P1W". All existing TF resources defined the "backup_repeating_time_intervals" property aren't added validation.

the documentation says ISO 8601 repeating time format - that is a variation of the standard duration format no?

please create a validation function like ISO8601Duration and add it to the helpers/time.go function and make use of it here/add to the other data protection resources

The validation is added.

neil-yechenwei · 2024-09-13T02:27:53Z

@katbyte , thanks for the comments. I updated PR. Please take another look. Thanks.

Below is the latest test result just now triggered.

katbyte · 2024-09-13T03:43:54Z

...rnal/services/dataprotection/data_protection_backup_policy_mysql_flexible_server_resource.go

+			MinItems: 1,
+			Elem: &pluginsdk.Schema{
+				Type:         pluginsdk.TypeString,
+				ValidateFunc: validation.StringIsNotEmpty,


the documentation says ISO 8601 repeating time format - that is a variation of the standard duration format no?

please create a validation function like ISO8601Duration and add it to the helpers/time.go function and make use of it here/add to the other data protection resources

...rnal/services/dataprotection/data_protection_backup_policy_mysql_flexible_server_resource.go

neil-yechenwei · 2024-09-14T01:37:33Z

@katbyte , thanks for the comments. I updated PR. Please take another look.

Below is the test result I just now triggered.

katbyte

Thanks @neil-yechenwei - LGTM 🏰

github-actions · 2024-10-21T02:15:51Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_data_protection_backup_policy_mysql_flexible_se…

d5f64a5

…rver

neil-yechenwei marked this pull request as draft August 7, 2024 04:31

github-actions bot added documentation service/data-protection size/XL labels Aug 7, 2024

ms-zhenhua suggested changes Aug 7, 2024

View reviewed changes

github-actions bot added the waiting-response label Aug 7, 2024

github-actions bot removed the waiting-response label Aug 8, 2024

update code

393ca94

neil-yechenwei requested a review from ms-zhenhua August 8, 2024 01:53

ms-zhenhua approved these changes Aug 9, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review August 9, 2024 02:59

katbyte requested changes Sep 13, 2024

View reviewed changes

github-actions bot added the waiting-response label Sep 13, 2024

add validate for timezone

070f4df

github-actions bot removed the waiting-response label Sep 13, 2024

neil-yechenwei requested a review from katbyte September 13, 2024 02:27

github-actions bot added the waiting-response label Sep 13, 2024

katbyte requested changes Sep 13, 2024

View reviewed changes

add validation for backup_repeating_time_intervals

ad06b3f

github-actions bot removed the waiting-response label Sep 14, 2024

neil-yechenwei requested a review from katbyte September 14, 2024 01:37

katbyte approved these changes Sep 20, 2024

View reviewed changes

katbyte merged commit 596a61e into hashicorp:main Sep 20, 2024

katbyte added a commit that referenced this pull request Sep 20, 2024

Update CHANGELOG.md #26955

eccb825

github-actions bot added this to the v4.3.0 milestone Sep 20, 2024

github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024

Conversation

neil-yechenwei commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Uh oh!

ms-zhenhua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neil-yechenwei commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ms-zhenhua commented Aug 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katbyte Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

katbyte Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

katbyte Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Sep 14, 2024

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katbyte Sep 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

neil-yechenwei commented Sep 14, 2024

Uh oh!

katbyte left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

neil-yechenwei commented Aug 7, 2024 •

edited

Loading

neil-yechenwei commented Aug 8, 2024 •

edited

Loading

neil-yechenwei commented Sep 13, 2024 •

edited

Loading