web_application_firewall_policy - Adds support for requestBodyEnforcement

[lcssanches]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add support for requestBodyEnforcement available in Application Gateway WAF policy.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

For state migrations please test the changes locally and provide details here, such as the versions involved in testing the migration path. For further details on testing state migration changes please see our guide on state migrations in the contributor documentation. -->

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• web_application_firewall_policy - Adds support for requestBodyEnforcement

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #25420

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this PR @lcssanches! I left some comments in-line which should be addressed. If you can take a look at those and get them fixed up then I can run the tests and this should be good to go.

[lcssanches]

Appreciate your review @stephybun .

I applied your suggestions, and I've changed the test to make request_body_enforcement = false in the "complete" config. (however not 100% sure it's correct as I am not familiar with these tests)

[stephybun]

Thanks @lcssanches those changes to the test are exactly what I wanted! The acceptance tests are passing and this will be good to go in once the formatting of the test config has been fixed. You can do this by running

terrafmt fmt -f internal/services/network/web_application_firewall_policy_resource_test.go

[lcssanches]

Thanks @lcssanches those changes to the test are exactly what I wanted! The acceptance tests are passing and this will be good to go in once the formatting of the test config has been fixed. You can do this by running

terrafmt fmt -f internal/services/network/web_application_firewall_policy_resource_test.go

done 👍

[stephybun]

Thanks @lcssanches LGTM 🦖

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.