New resource: azurerm_netapp_backup_vault and azurerm_netapp_backup_policy#27188
New resource: azurerm_netapp_backup_vault and azurerm_netapp_backup_policy#27188mbfrahry merged 36 commits intohashicorp:mainfrom
azurerm_netapp_backup_vault and azurerm_netapp_backup_policy#27188Conversation
… snapshot_directory_visible
…test provider block
github-actions
bot
added
documentation
dependencies
service/netapp
size/XL
waiting-response
labels
|
The unit tests failing below have nothing to do with my changes. |
mbfrahry
left a comment
mbfrahry
left a comment
There was a problem hiding this comment.
Hey @paulomarquesc, sorry for the delay in this review. Overall it looks good but it looks like underlying sdk got swapped out from underneath this PR and that'll need to be fixed.
mbfrahry
left a comment
mbfrahry
left a comment
There was a problem hiding this comment.
Hey @paulomarquesc, I've taken another pass and it overall looks to be in a good place but I've left quite a few comments to clean up some of the messaging and a few other design cleanups that we should do
mbfrahry
left a comment
mbfrahry
left a comment
There was a problem hiding this comment.
Hey @paulomarquesc, this is looking better! I just left a note around a missing nil check and then moving the _maintainers/readme file into the main netapp folder while also cleaning up some of the formatting
| } | ||
| ``` | ||
|
|
||
| This is because some operations return from regular SDK polling as completed but due to several factors it is still in progress (e.g. ARM caching, software and hardware layer sync delays, etc.). These wait functions are necessary and should not be removed. |
There was a problem hiding this comment.
The formatting here got weird (some words have colors) and I'm worried it'll cause issues when people view the file? I believe it's because of the above code block being tabbed over but you'll have to mess with it and see
There was a problem hiding this comment.
On VS Code Markdown preview it looks ok:
There was a problem hiding this comment.
I think it is some bug on GitHub PR interface because if you also navigate in my branch itself, it shows up normal:
|
|
||
| In our tests we have added this block so the tests can delete the resources, but in production customers should not allow deletion of volumes by default. | ||
|
|
||
| ```hcl |
There was a problem hiding this comment.
If formatting the above code block works, we'll want to do the same with this code block
mbfrahry
changed the title
azurerm_netapp_backup_vault and azurerm_netapp_backup_policyazurerm_netapp_backup_vault and azurerm_netapp_backup_policy
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
7 participants
Community Note
Description
This PR consists of:
netapp_backup_vaultandnetapp_backup_policynetappfeature configuration block focused on safety as follows:prevent_volume_destruction- Set totrueby default, prevents a very common occurrence for Azure NetApp customers losing data due to volume destruction. This will change current behavior of volume destruction, and they will fail destruction if not set but this is required to be set now since we have many Azure customers (for various reasons) losing their volumes and for Azure NetApp Files, this is a non-recoverable disaster.delete_backups_on_backup_vault_destroy- Set tofalseby default, this will protect customers from having their backups destroyed, making sure customers can restore their data.prevent_volume_destructionwas added and set tofalseto all acceptance tests that requires volume resource to allow it to clean up the test and complete it successfully2024-03-01snapshot_directory_visiblevolume configuration preventing acceptance tests for CRR to completePR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_netapp_backup_vault- add support for backup vaults that are the parents of backups and it is associated with a volume.azurerm_netapp_backup_policy- a backup policy to assign to a volume that indicates that volume will start to have internally scheduled backups and what is the retention policy.This is a (please select all that apply):
Related Issue(s)
Fixes #16242