azurerm_bot_service_azure_bot - send value for developer_app_insights_api_key

[stephybun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The DiffSuppress on the property was preventing the config value for developer_app_insights_api_key from being read and subsequently set in the payload properly.

When tweaking the logic in the DiffSuppress I found that the logic required to correctly read the config value would result in a plan diff after applying because it wouldn't correctly suppress the diff anymore.

I've opted to remove the DiffSuppress entirely and set the value for this property in the read by taking it from the config like we do in other resources of the provider where sensitive properties aren't returned by the API.

When upgrading to a version that contains this fix users will receive an update in-place diff but it will be a no-op since the value for the property isn't changing. Applying the update will update the resource with the API key value as well as set it into state for the user. Given that this wasn't truly working at all previously, this should be acceptable for a minor release.

Testing

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[mbfrahry]

LGTM

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.