kusto_cluster_resource - allowed_fqdns and allowed_ip_ranges properties can be empty list when update#27529
Merged
stephybun merged 2 commits intohashicorp:mainfrom Nov 21, 2024
Conversation
…optional-list-of-string-error
Collaborator
Author
|
Hi @katbyte, I have reran those tests and some were passing, there were still 2 tests failed but those were due to other reasons that are not related to the change of the current pr. |
stephybun
approved these changes
Nov 21, 2024
Member
stephybun
left a comment
There was a problem hiding this comment.
Thanks @hqhqhqhqhqhqhqhqhqhqhq LGTM 👍
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Community Note
Description
For resource
kusto_cluster_resource,allowed_fqdnsandallowed_ip_rangesare optional properties that can receive a list as value. The resource can be created withallowed_fqdnsandallowed_ip_rangesset as empty list, but when update, if these are declared, there will be an error.This PR removes that error and allow empty list value for those when update.
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #27132
Note
If this PR changes meaningfully during the course of review please update the title and description as required.