azurerm_app_service_certificate - support for versionless key_vault_secret_id#27537
Merged
catriona-m merged 1 commit intomainfrom Oct 3, 2024
Merged
azurerm_app_service_certificate - support for versionless key_vault_secret_id#27537catriona-m merged 1 commit intomainfrom
azurerm_app_service_certificate - support for versionless key_vault_secret_id#27537catriona-m merged 1 commit intomainfrom
Conversation
jackofallops
approved these changes
Oct 3, 2024
Member
jackofallops
left a comment
There was a problem hiding this comment.
Thanks @catriona-m - LGTM 👍
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
=== RUN TestAccAppServiceCertificate_KeyVaultIdVersionless
=== PAUSE TestAccAppServiceCertificate_KeyVaultIdVersionless
=== CONT TestAccAppServiceCertificate_KeyVaultIdVersionless
--- PASS: TestAccAppServiceCertificate_KeyVaultIdVersionless (883.93s)
PASS
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_app_service_certificate- support for versionlesskey_vault_secret_id[GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #23237
Note
If this PR changes meaningfully during the course of review please update the title and description as required.