New Resource: `azurerm_system_center_virtual_machine_manager_virtual_machine_instance` by neil-yechenwei · Pull Request #27622 · hashicorp/terraform-provider-azurerm

neil-yechenwei · 2024-10-11T07:18:40Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support System Center Virtual Machine Manager Virtual Machine Instance. It is a virtual machine instance management tool primarily used for managing virtual resources in private and hybrid cloud environments.

Note: SCVMM is part of Microsoft System Center and is specifically designed to centrally manage data center virtualization infrastructure.

API reference: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/scvmm/resource-manager/Microsoft.ScVmm/stable/2023-10-07/scvmm.json

Overview: https://learn.microsoft.com/en-us/azure/azure-arc/system-center-virtual-machine-manager/overview

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/basic (764.98s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/requiresImport (840.68s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/complete (825.70s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/update (934.30s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/inventoryItemId (330.69s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_instance

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…achine_instance

…machinemanagervirtualmachineinstance

neil-yechenwei · 2024-12-05T08:31:38Z

@catriona-m , thanks for the comments. I updated PR. Please take another look. Below is the latest test result that I just now triggered.

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/basic (850.75s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/requiresImport (943.84s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/complete (1119.72s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/update (2363.51s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/inventoryItemId (878.34s)

…machinemanagervirtualmachineinstance

catriona-m

Thanks @neil-yechenwei - I just noticed one more item in the tests but if you could fix that up and re-run them, I can take another look. Thanks!

catriona-m · 2025-01-15T16:56:46Z

...chinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource_test.go

+  operating_system {
+    computer_name = "testComputer"
+  }
+
+  hardware {
+    cpu_count    = 1
+    memory_in_mb = 1024
+  }
+
+  network_interface {
+    name              = "testNIC"
+    ipv4_address_type = "Dynamic"
+    ipv6_address_type = "Dynamic"
+    mac_address_type  = "Dynamic"
+  }


these blocks are optional so we should omit them from the basic test

…machinemanagervirtualmachineinstance

catriona-m · 2025-01-16T10:01:24Z

...chinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource_test.go

 			),
 		},
-		data.ImportStep(),
+		data.ImportStep("operating_system", "hardware", "network_interface"),


we shouldn't need to ignore these fields?

Yes. I removed them.

neil-yechenwei · 2025-01-21T09:33:25Z

@catriona-m , thanks for the comments. I updated PR. Please take another look. Below is the test result that I just now triggered.

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/basic (780.81s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/requiresImport (841.72s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/complete (892.91s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/update (1136.20s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualMachineInstanceSequential/scvmmVirtualMachineInstance/inventoryItemId (321.41s)

...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go

neil-yechenwei · 2025-02-17T00:57:02Z

@catriona-m , thanks for the comments. Please take another look for this PR. Thanks.

catriona-m

Thanks @neil-yechenwei LGTM!

* Update CHANGELOG.md #28843 * Update CHANGELOG.md for #28748 * Update CHANGELOG.md for #28881 * Update CHANGELOG.md for #28909 * Update CHANGELOG.md fold in patch release and expand starred entry correctly * Update CHANGELOG.md remove duplicate entry for 28843 * Update CHANGELOG.md #28066 * Update CHANGELOG.md for #28902 and fix ordering * Update CHANGELOG.md for #28848 * Update CHANGELOG.md #27622 * Update CHANGELOG.md for #28271 * Update CHANGELOG.md update format * Update CHANGELOG.md #28934 * Update for #28619 #28598 * Update CHANGELOG.md #28940 * Update CHANGELOG.md for #28880 * Update CHANGELOG.md for #28617 * Update CHANGELOG.md #28721 * Update CHANGELOG.md #28949 * Update previous entry for 4.16.0 * Update CHANGELOG.md for #28834 * prep for release --------- Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: jackofallops <ste@hashicorp.com>

github-actions · 2025-04-03T02:17:30Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 30 commits December 5, 2023 12:12

New Resource: azurerm_system_center_virtual_machine_manager_virtual_m…

e3ac09d

…achine_instance

update code

ada2088

update code

8e5a5bf

update code

5b46fee

update code

997cf29

update code

6f7d2ea

merge latest change

abe39d6

merge latest change

7b084ed

rename property

2fb19a0

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

7c6fa7e

…machinemanagervirtualmachineinstance

add md file and tc

bf3371f

update schema

1d36a47

remove requiredwith

71bfa14

update shcema

da46bb1

update schema

53c70b2

mark os.computer_name to required

7483211

update schema

5104437

expand os

65b0065

add validation for storage disk name

906c477

add validation

a3499b1

add tc

f9d483b

add restart

5e6dada

remove default value

ad411da

update validation for vnetid

2f31577

remove readonly property createDiffdisk

550d3e2

add stop

57963ec

update tc

54a190b

update tc to add avs

157aa81

update tc to test vnetid

718d648

update md

141f00f

format go

76280ad

github-actions bot added waiting-response and removed waiting-response labels Dec 5, 2024

neil-yechenwei requested a review from catriona-m December 5, 2024 08:31

github-actions bot removed the waiting-response label Dec 5, 2024

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

e592613

…machinemanagervirtualmachineinstance

catriona-m requested changes Jan 15, 2025

View reviewed changes

github-actions bot added the waiting-response label Jan 15, 2025

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

9fc4505

…machinemanagervirtualmachineinstance

github-actions bot removed the waiting-response label Jan 16, 2025

update basic tc

da6a498

catriona-m reviewed Jan 16, 2025

View reviewed changes

github-actions bot added the waiting-response label Jan 16, 2025

github-actions bot removed the waiting-response label Jan 21, 2025

move the properties to ignore_changes

f9ba9e2

neil-yechenwei requested a review from catriona-m January 21, 2025 11:32

catriona-m reviewed Jan 29, 2025

View reviewed changes

...ualmachinemanager/system_center_virtual_machine_manager_virtual_machine_instance_resource.go Show resolved Hide resolved

github-actions bot added the waiting-response label Jan 29, 2025

neil-yechenwei requested a review from catriona-m February 6, 2025 04:27

github-actions bot removed the waiting-response label Feb 6, 2025

catriona-m approved these changes Mar 3, 2025

View reviewed changes

catriona-m merged commit 2422e63 into hashicorp:main Mar 3, 2025
35 checks passed

github-actions bot added this to the v4.22.0 milestone Mar 3, 2025

catriona-m added a commit that referenced this pull request Mar 3, 2025

Update CHANGELOG.md #27622

cd80e92

github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_system_center_virtual_machine_manager_virtual_machine_instance`#27622

New Resource: `azurerm_system_center_virtual_machine_manager_virtual_machine_instance`#27622
catriona-m merged 59 commits intohashicorp:mainfrom
neil-yechenwei:systemcentervirtualmachinemanagervirtualmachineinstance

neil-yechenwei commented Oct 11, 2024 •

edited

Loading

Uh oh!

neil-yechenwei commented Dec 5, 2024 •

edited

Loading

Uh oh!

catriona-m left a comment

Uh oh!

catriona-m Jan 15, 2025

Uh oh!

neil-yechenwei Jan 16, 2025 •

edited

Loading

Uh oh!

catriona-m Jan 16, 2025

Uh oh!

neil-yechenwei Jan 21, 2025

Uh oh!

neil-yechenwei commented Jan 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

neil-yechenwei commented Feb 17, 2025 •

edited

Loading

Uh oh!

catriona-m left a comment

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

neil-yechenwei commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Uh oh!

neil-yechenwei commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

catriona-m Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

catriona-m Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

neil-yechenwei commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

neil-yechenwei commented Oct 11, 2024 •

edited

Loading

neil-yechenwei commented Dec 5, 2024 •

edited

Loading

neil-yechenwei Jan 16, 2025 •

edited

Loading

neil-yechenwei commented Jan 21, 2025 •

edited

Loading

neil-yechenwei commented Feb 17, 2025 •

edited

Loading