`azurerm_cosmosdb_account` - support new version of `mongo_server_version` by sinbai · Pull Request #27763 · hashicorp/terraform-provider-azurerm

sinbai · 2024-10-25T09:45:47Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
[] (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccCosmosDBAccount_mongoVersion70 (972.01s)
PASS: TestAccCosmosDBAccount_mongoVersion60 (949.42s)
PASS: TestAccCosmosDBAccount_mongoVersion50 (1157.10s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_cosmosdb_account - support new version of mongo_server_version[Support for CosmosDB API Mongo 7.0 #27605]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #27605

anton-x-t · 2024-10-28T11:49:33Z

@katbyte Hi! Thank you for earlier work in this repository. Can you please review this pull request? :)

stephybun · 2024-10-28T12:38:04Z

internal/services/cosmos/cosmosdb_account_resource_test.go

+func (CosmosDBAccountResource) basicMongoDBVersion50(data acceptance.TestData, consistency cosmosdb.DefaultConsistencyLevel) string {
+	return fmt.Sprintf(`
+provider "azurerm" {
+  features {}
+}
+
+resource "azurerm_resource_group" "test" {
+  name     = "acctestRG-cosmos-%d"
+  location = "%s"
+}
+
+resource "azurerm_cosmosdb_account" "test" {
+  name                 = "acctest-ca-%d"
+  location             = azurerm_resource_group.test.location
+  resource_group_name  = azurerm_resource_group.test.name
+  offer_type           = "Standard"
+  kind                 = "MongoDB"
+  mongo_server_version = "5.0"
+
+  capabilities {
+    name = "EnableMongo"
+  }
+
+  consistency_policy {
+    consistency_level = "%s"
+  }
+
+  geo_location {
+    location          = azurerm_resource_group.test.location
+    failover_priority = 0
+  }
+}
+`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, string(consistency))
+}
+
+func (CosmosDBAccountResource) basicMongoDBVersion60(data acceptance.TestData, consistency cosmosdb.DefaultConsistencyLevel) string {
+	return fmt.Sprintf(`
+provider "azurerm" {
+  features {}
+}
+
+resource "azurerm_resource_group" "test" {
+  name     = "acctestRG-cosmos-%d"
+  location = "%s"
+}
+
+resource "azurerm_cosmosdb_account" "test" {
+  name                 = "acctest-ca-%d"
+  location             = azurerm_resource_group.test.location
+  resource_group_name  = azurerm_resource_group.test.name
+  offer_type           = "Standard"
+  kind                 = "MongoDB"
+  mongo_server_version = "6.0"
+
+  capabilities {
+    name = "EnableMongo"
+  }
+
+  consistency_policy {
+    consistency_level = "%s"
+  }
+
+  geo_location {
+    location          = azurerm_resource_group.test.location
+    failover_priority = 0
+  }
+}
+`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, string(consistency))
+}
+
+func (CosmosDBAccountResource) basicMongoDBVersion70(data acceptance.TestData, consistency cosmosdb.DefaultConsistencyLevel) string {
+	return fmt.Sprintf(`
+provider "azurerm" {
+  features {}
+}
+
+resource "azurerm_resource_group" "test" {
+  name     = "acctestRG-cosmos-%d"
+  location = "%s"
+}
+
+resource "azurerm_cosmosdb_account" "test" {
+  name                 = "acctest-ca-%d"
+  location             = azurerm_resource_group.test.location
+  resource_group_name  = azurerm_resource_group.test.name
+  offer_type           = "Standard"
+  kind                 = "MongoDB"
+  mongo_server_version = "7.0"
+
+  capabilities {
+    name = "EnableMongo"
+  }
+
+  consistency_policy {
+    consistency_level = "%s"
+  }
+
+  geo_location {
+    location          = azurerm_resource_group.test.location
+    failover_priority = 0
+  }
+}
+`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, string(consistency))
+}


These test configs are all identical except for the mongo server version. Can you please parameterize this test so we can avoid the duplication and pass the mongo server version in as an argument.

Hi @stephybun thanks for your time and feedback. Sure, I have parameterized the test. Could you please take another look? Thanks.

stephybun

Thanks @sinbai LGTM 🦕

anton-x-t · 2024-10-29T10:49:59Z

Thank you very much @sinbai and @stephybun 👍 👍 👍

github-actions · 2024-11-29T02:17:40Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

support new values of mongo_server_version

5d5b166

sinbai requested review from a team and katbyte as code owners October 25, 2024 09:45

github-actions bot added documentation service/cosmosdb size/L labels Oct 25, 2024

Gwenael22 mentioned this pull request Oct 25, 2024

Support for MongoDB API versions 5.0 and 6.0 #25889

Closed

1 task

kosoniu approved these changes Oct 25, 2024

View reviewed changes

michalwilk96 approved these changes Oct 25, 2024

View reviewed changes

anton-x-t approved these changes Oct 25, 2024

View reviewed changes

stephybun suggested changes Oct 28, 2024

View reviewed changes

github-actions bot added the waiting-response label Oct 28, 2024

rcskosir added the enhancement label Oct 28, 2024

fix comments

f09c0b8

github-actions bot added size/M waiting-response and removed waiting-response size/L labels Oct 29, 2024

update test case

3b90e54

github-actions bot removed the waiting-response label Oct 29, 2024

stephybun approved these changes Oct 29, 2024

View reviewed changes

stephybun merged commit 8ae8bc8 into hashicorp:main Oct 29, 2024

github-actions bot added this to the v4.8.0 milestone Oct 29, 2024

stephybun added a commit that referenced this pull request Oct 29, 2024

Update for #27763

9c3e394

github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_cosmosdb_account` - support new version of `mongo_server_version`#27763

`azurerm_cosmosdb_account` - support new version of `mongo_server_version`#27763
stephybun merged 3 commits intohashicorp:mainfrom
sinbai:cosmos/support_new_versions

sinbai commented Oct 25, 2024

Uh oh!

anton-x-t commented Oct 28, 2024

Uh oh!

stephybun Oct 28, 2024

Uh oh!

sinbai Oct 29, 2024

Uh oh!

stephybun left a comment

Uh oh!

anton-x-t commented Oct 29, 2024

Uh oh!

github-actions bot commented Nov 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

sinbai commented Oct 25, 2024

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

anton-x-t commented Oct 28, 2024

Uh oh!

stephybun Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

sinbai Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

anton-x-t commented Oct 29, 2024

Uh oh!

github-actions bot commented Nov 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants