azurerm_data_protection_backup_vault - support for immutability property#27859
Merged
azurerm_data_protection_backup_vault - support for immutability property#27859
azurerm_data_protection_backup_vault - support for immutability property#27859Conversation
mbfrahry
requested changes
Nov 12, 2024
internal/services/dataprotection/data_protection_backup_vault_resource.go
Outdated
Show resolved
Hide resolved
internal/services/dataprotection/data_protection_backup_vault_resource.go
Show resolved
Hide resolved
merge main
github-actions
bot
added
size/M
waiting-response
and removed
waiting-response
size/S
labels
mbfrahry
requested changes
Nov 15, 2024
Member
mbfrahry
left a comment
mbfrahry
left a comment
There was a problem hiding this comment.
The CustomizeDiff is perfect but the way it's currently written is a breaking change if people move between versions. I've left comments for how to get it working without it being a breaking change
internal/services/dataprotection/data_protection_backup_vault_resource.go
Outdated
Show resolved
Hide resolved
internal/services/dataprotection/data_protection_backup_vault_resource.go
Outdated
Show resolved
Hide resolved
|
@mbfrahry can you re-review? |
4 tasks
mbfrahry
changed the title
azurerm_data_protection_backup_vault - support for immutability property
mbfrahry
added a commit
that referenced
this pull request
Jan 15, 2025
jackofallops
added a commit
that referenced
this pull request
Jan 16, 2025
* update for #27680 * Update CHANGELOG.md for #28465 * Update CHANGELOG.md #27932 * Update CHANGELOG.md for #28505 * Update CHANGELOG.md for #28474 * Update CHANGELOG.md #28516 * Update CHANGELOG for #28456 * Update CHANGELOG.md for #28472 * Update CHANGELOG.md #28307 * Update CHANGELOG.md for #27859 * Update for #28519 * Update for #27791 #27528 * Update CHANGELOG.md for #28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
NotTheEvilOne
pushed a commit
to b1-systems/terraform-provider-azurerm
that referenced
this pull request
Jan 20, 2025
NotTheEvilOne
pushed a commit
to b1-systems/terraform-provider-azurerm
that referenced
this pull request
Jan 20, 2025
* update for hashicorp#27680 * Update CHANGELOG.md for hashicorp#28465 * Update CHANGELOG.md hashicorp#27932 * Update CHANGELOG.md for hashicorp#28505 * Update CHANGELOG.md for hashicorp#28474 * Update CHANGELOG.md hashicorp#28516 * Update CHANGELOG for hashicorp#28456 * Update CHANGELOG.md for hashicorp#28472 * Update CHANGELOG.md hashicorp#28307 * Update CHANGELOG.md for hashicorp#27859 * Update for hashicorp#28519 * Update for hashicorp#27791 hashicorp#27528 * Update CHANGELOG.md for hashicorp#28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_data_protection_backup_vault- support for immutability property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #22238
Note
If this PR changes meaningfully during the course of review please update the title and description as required.