Skip to content

network - upgrade to 2024-05-01#28146

Merged
stephybun merged 9 commits intohashicorp:mainfrom
teowa:network_2024-05-01
Jan 30, 2025
Merged

network - upgrade to 2024-05-01#28146
stephybun merged 9 commits intohashicorp:mainfrom
teowa:network_2024-05-01

Conversation

@teowa
Copy link
Collaborator

@teowa teowa commented Dec 2, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

In order to onboard the Network Manager IP Address Management feature.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@stephybun
Copy link
Member

@teowa I can't trigger the tests in TC because of a build failure, could you please rebase this PR?

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look alright. LGTM 🍯

@stephybun stephybun merged commit b094a9e into hashicorp:main Jan 30, 2025
30 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 30, 2025
stephybun added a commit that referenced this pull request Jan 30, 2025
jackofallops added a commit that referenced this pull request Jan 31, 2025
* Update for #27950

* Update for #27824

* Update for #28592 #28583 #28599 #28590 #28453

* Update #28528

* Update for #27853

* Update CHANGELOG.md #28221

* Update for #27760

* Update CHANGELOG.md #28480

* Update CHANGELOG.md typo

* Update CHANGELOG.md #28372

* Update CHANGELOG.md for #26047

also alphabetised ENHANCEMENTS

* Update for #28146

* Update CHANGELOG.md #28013

* Update CHANGELOG.md for #28492

* Update CHANGELOG.md for #28648

* Update CHANGELOG.md for #28549

* Update for #28469 #28620

* prep for release

* i touched it last

---------

Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
* upgrade network to 2024-05-01

* rename client

* go mod vendor

* go mod vendor

* remove network 2024-03-01
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
* Update for hashicorp#27950

* Update for hashicorp#27824

* Update for hashicorp#28592 hashicorp#28583 hashicorp#28599 hashicorp#28590 hashicorp#28453

* Update hashicorp#28528

* Update for hashicorp#27853

* Update CHANGELOG.md hashicorp#28221

* Update for hashicorp#27760

* Update CHANGELOG.md hashicorp#28480

* Update CHANGELOG.md typo

* Update CHANGELOG.md hashicorp#28372

* Update CHANGELOG.md for hashicorp#26047

also alphabetised ENHANCEMENTS

* Update for hashicorp#28146

* Update CHANGELOG.md hashicorp#28013

* Update CHANGELOG.md for hashicorp#28492

* Update CHANGELOG.md for hashicorp#28648

* Update CHANGELOG.md for hashicorp#28549

* Update for hashicorp#28469 hashicorp#28620

* prep for release

* i touched it last

---------

Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: jackofallops <ste@hashicorp.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants