azurerm_logic_app_standard - fix setting public_network_access for conflicting API properties#28465
Merged
jackofallops merged 3 commits intomainfrom Jan 13, 2025
Merged
azurerm_logic_app_standard - fix setting public_network_access for conflicting API properties#28465jackofallops merged 3 commits intomainfrom
azurerm_logic_app_standard - fix setting public_network_access for conflicting API properties#28465jackofallops merged 3 commits intomainfrom
Conversation
github-actions
bot
added
bug
service/logic
size/XS
waiting-response
dependencies
size/M
and removed
waiting-response
size/XS
labels
jackofallops
force-pushed
the
b/logic-app-pna-again
branch
from
bff3f1c to
e0c50a8
Compare
stephybun
reviewed
Jan 13, 2025
Co-authored-by: stephybun <steph@hashicorp.com>
stephybun
approved these changes
Jan 13, 2025
Member
stephybun
left a comment
stephybun
left a comment
There was a problem hiding this comment.
Thanks @jackofallops LGTM 🐗
Member
Author
|
Tests look good:
|
jackofallops
added a commit
that referenced
this pull request
Jan 13, 2025
jackofallops
added a commit
that referenced
this pull request
Jan 16, 2025
* update for #27680 * Update CHANGELOG.md for #28465 * Update CHANGELOG.md #27932 * Update CHANGELOG.md for #28505 * Update CHANGELOG.md for #28474 * Update CHANGELOG.md #28516 * Update CHANGELOG for #28456 * Update CHANGELOG.md for #28472 * Update CHANGELOG.md #28307 * Update CHANGELOG.md for #27859 * Update for #28519 * Update for #27791 #27528 * Update CHANGELOG.md for #28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
NotTheEvilOne
pushed a commit
to b1-systems/terraform-provider-azurerm
that referenced
this pull request
Jan 20, 2025
…r conflicting API properties (hashicorp#28465) * workaround dual setting problem * refactor eval for reconciling PNA between 2 locations * accept suggestion Co-authored-by: stephybun <steph@hashicorp.com> --------- Co-authored-by: stephybun <steph@hashicorp.com>
NotTheEvilOne
pushed a commit
to b1-systems/terraform-provider-azurerm
that referenced
this pull request
Jan 20, 2025
* update for hashicorp#27680 * Update CHANGELOG.md for hashicorp#28465 * Update CHANGELOG.md hashicorp#27932 * Update CHANGELOG.md for hashicorp#28505 * Update CHANGELOG.md for hashicorp#28474 * Update CHANGELOG.md hashicorp#28516 * Update CHANGELOG for hashicorp#28456 * Update CHANGELOG.md for hashicorp#28472 * Update CHANGELOG.md hashicorp#28307 * Update CHANGELOG.md for hashicorp#27859 * Update for hashicorp#28519 * Update for hashicorp#27791 hashicorp#27528 * Update CHANGELOG.md for hashicorp#28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Fixes a bug in setting
publicNetworkAccessdue to this being set in two places currently which can conflict with each other and cause inconsistent behaviour.Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_logic_app_standard- fix settingpublic_network_accessfor conflicting API propertiesThis is a (please select all that apply):
Related Issue(s)
Closes #27398
Note
If this PR changes meaningfully during the course of review please update the title and description as required.