`azurerm_*function_app`, `azurerm_linux_web_app` - add node 22 and java 17 support for JBOSSEAP by xiaxyi · Pull Request #28472 · hashicorp/terraform-provider-azurerm

xiaxyi · 2025-01-10T03:08:54Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add node 22 support for function app and java 17 support for JBOSSEAP for linux web app

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #28302
Fixes #28350

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

jackofallops

Thanks @xiaxyi - Just one change to take a look at if you could, the rest I think is good to go.

jackofallops · 2025-01-13T06:44:58Z

internal/services/appservice/linux_function_app_resource_test.go

+			Config: r.appStackNode(data, SkuBasicPlan, "22"),
+			Check: acceptance.ComposeTestCheckFunc(
+				check.That(data.ResourceName).ExistsInAzure(r),
+				check.That(data.ResourceName).Key("kind").HasValue("functionapp,linux"),
+				check.That(data.ResourceName).Key("site_config.0.linux_fx_version").HasValue("NODE|20"),


Copy paste error here?

Suggested change

Config: r.appStackNode(data, SkuBasicPlan, "22"),

Check: acceptance.ComposeTestCheckFunc(

check.That(data.ResourceName).ExistsInAzure(r),

check.That(data.ResourceName).Key("kind").HasValue("functionapp,linux"),

check.That(data.ResourceName).Key("site_config.0.linux_fx_version").HasValue("NODE|20"),

Config: r.appStackNode(data, SkuBasicPlan, "22"),

Check: acceptance.ComposeTestCheckFunc(

check.That(data.ResourceName).ExistsInAzure(r),

check.That(data.ResourceName).Key("kind").HasValue("functionapp,linux"),

check.That(data.ResourceName).Key("site_config.0.linux_fx_version").HasValue("NODE|22"),

xiaxyi · 2025-01-13T08:05:50Z

Thanks @jackofallops for the comment, I fixed the typo.

jackofallops

Thanks @xiaxyi - LGTM now 👍

* update for #27680 * Update CHANGELOG.md for #28465 * Update CHANGELOG.md #27932 * Update CHANGELOG.md for #28505 * Update CHANGELOG.md for #28474 * Update CHANGELOG.md #28516 * Update CHANGELOG for #28456 * Update CHANGELOG.md for #28472 * Update CHANGELOG.md #28307 * Update CHANGELOG.md for #27859 * Update for #28519 * Update for #27791 #27528 * Update CHANGELOG.md for #28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>

…va 17 support for JBOSSEAP (hashicorp#28472) * add node 22 and java 17 support for JBOSSEAP * update docs * fix typo

* update for hashicorp#27680 * Update CHANGELOG.md for hashicorp#28465 * Update CHANGELOG.md hashicorp#27932 * Update CHANGELOG.md for hashicorp#28505 * Update CHANGELOG.md for hashicorp#28474 * Update CHANGELOG.md hashicorp#28516 * Update CHANGELOG for hashicorp#28456 * Update CHANGELOG.md for hashicorp#28472 * Update CHANGELOG.md hashicorp#28307 * Update CHANGELOG.md for hashicorp#27859 * Update for hashicorp#28519 * Update for hashicorp#27791 hashicorp#27528 * Update CHANGELOG.md for hashicorp#28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>

Amends 918d96c (hashicorp#28472), which missed some spots.

orgads · 2025-01-23T10:55:22Z

This still doesn't work. I found some missing spots: main...orgads:terraform-provider-azurerm:node-22

I don't know how to cover this in tests, so please take it from here.

xiaxyi · 2025-01-26T03:08:36Z

@orgads I don't think node 22 is supported for linux web app? At least the option seems not available in Azure portal?

Are you able to see node 22 for linux web app in Azure portal?

orgads · 2025-01-26T04:05:15Z

It doesn't appear for Flex Consumption, but it does for Consumption on both Linux and Windows.

orgads · 2025-02-06T07:49:07Z

@xiaxyi Can you please complete this?

Amends 918d96c (hashicorp#28472), which missed some spots.

github-actions · 2025-03-09T02:08:22Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

add node 22 and java 17 support for JBOSSEAP

918d96c

xiaxyi requested a review from a team as a code owner January 10, 2025 03:08

github-actions bot added service/app-service size/XS enhancement labels Jan 10, 2025

update docs

be3a270

github-actions bot added the documentation label Jan 10, 2025

jackofallops self-assigned this Jan 13, 2025

jackofallops requested changes Jan 13, 2025

View reviewed changes

github-actions bot added the waiting-response label Jan 13, 2025

fix typo

c1653fa

github-actions bot removed the waiting-response label Jan 13, 2025

jackofallops approved these changes Jan 15, 2025

View reviewed changes

jackofallops merged commit 13d824b into hashicorp:main Jan 15, 2025
33 checks passed

github-actions bot added this to the v4.16.0 milestone Jan 15, 2025

jackofallops added a commit that referenced this pull request Jan 15, 2025

Update CHANGELOG.md for #28472

0b2da42

orgads added a commit to orgads/terraform-provider-azurerm that referenced this pull request Jan 23, 2025

azurerm_*function_app: Really support Node.JS version 22

68fd5d2

Amends 918d96c (hashicorp#28472), which missed some spots.

wojtekmaj mentioned this pull request Feb 6, 2025

Add Node.js 22 in function application_stack and Azure Web App application_stack #28081

Closed

14 tasks

orgads added a commit to orgads/terraform-provider-azurerm that referenced this pull request Feb 9, 2025

azurerm_*function_app: Really support Node.JS version 22

24ca540

Amends 918d96c (hashicorp#28472), which missed some spots.

github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_*function_app`, `azurerm_linux_web_app` - add node 22 and java 17 support for JBOSSEAP#28472

`azurerm_*function_app`, `azurerm_linux_web_app` - add node 22 and java 17 support for JBOSSEAP#28472
jackofallops merged 3 commits intohashicorp:mainfrom
xiaxyi:appservice/addruntime

xiaxyi commented Jan 10, 2025 •

edited

Loading

Uh oh!

jackofallops left a comment

Uh oh!

jackofallops Jan 13, 2025

Uh oh!

xiaxyi commented Jan 13, 2025

Uh oh!

jackofallops left a comment

Uh oh!

Uh oh!

orgads commented Jan 23, 2025

Uh oh!

xiaxyi commented Jan 26, 2025

Uh oh!

orgads commented Jan 26, 2025

Uh oh!

orgads commented Feb 6, 2025

Uh oh!

github-actions bot commented Mar 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

xiaxyi commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

jackofallops left a comment

Choose a reason for hiding this comment

Uh oh!

jackofallops Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

xiaxyi commented Jan 13, 2025

Uh oh!

jackofallops left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

orgads commented Jan 23, 2025

Uh oh!

xiaxyi commented Jan 26, 2025

Uh oh!

orgads commented Jan 26, 2025

Uh oh!

orgads commented Feb 6, 2025

Uh oh!

github-actions bot commented Mar 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xiaxyi commented Jan 10, 2025 •

edited

Loading