Skip to content

azurerm_key_vault_secret: remove expiration triage recreate#28494

Merged
stephybun merged 2 commits intohashicorp:mainfrom
wuxu92:key/secret-expiration-date
Feb 26, 2025
Merged

azurerm_key_vault_secret: remove expiration triage recreate#28494
stephybun merged 2 commits intohashicorp:mainfrom
wuxu92:key/secret-expiration-date

Conversation

@wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Jan 14, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

As describe in issue: #28355 (comment) . The expiration date cannot be removed once set. So this PR is to add the forceNew logic for it.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
Terraform will perform the following actions:

  # azurerm_key_vault_secret.test must be replaced
-/+ resource "azurerm_key_vault_secret" "test" {
      - expiration_date         = "2026-01-01T01:02:03Z" -> null # forces replacement

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28355

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 👍

@stephybun stephybun merged commit e91d217 into hashicorp:main Feb 26, 2025
33 checks passed
@github-actions github-actions bot added this to the v4.21.0 milestone Feb 26, 2025
@wuxu92 wuxu92 deleted the key/secret-expiration-date branch February 26, 2025 09:56
stephybun added a commit that referenced this pull request Feb 26, 2025
jackofallops added a commit that referenced this pull request Feb 27, 2025
* Update CHANGELOG.md for #28840

* Update CHANGELOG.md #28808

* Update CHANGELOG.md #27962

* Update CHANGELOG.md for #28859

* Update for #28825

* Update CHANGELOG.md for #28864

* Update CHANGELOG.md #28539

* Update CHANGELOG.md #28685

* Update CHANGELOG.md for #28818

* Update for #28857 #28799 #28856

* Update for #28122

* Update for #28248 #27805

* Update for #28853

* Update for #28316 #28494 #28696

* Update for #28754

* Update CHANGELOG.md #28771

* Update CHANGELOG.md #28842

* Update for #28879

* Update for #28199

* Update CHANGELOG.md #28862

* prep for release v4.21.0

---------

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
wuxu92 added a commit to wuxu92/terraform-provider-azurerm that referenced this pull request Mar 6, 2025
… removing

the expiration_date by an update
stephybun pushed a commit that referenced this pull request Mar 18, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_secret can't remove expiration_date

2 participants