azurerm_virtual_hub_connection - adding property static_vnet_propagate_static_routes

[aeimer]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This is my try to add PropagateStaticRoutes to azurerm_virtual_hub_connection.

closes #28556

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

I can't test it locally, as I have no Azure subscription to deploy it to.

I was able to run make pr-check locally without errors.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== PAUSE TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== CONT  TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
--- PASS: TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes (2617.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/network	2620.254s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_virtual_hub_connection - adding property static_vnet_propagate_static_routes (Support for setting propagateStaticRoutes in azurerm_virtual_hub_connection #28556)

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28556

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[aeimer]

I just re-ran the acceptance tests on the commit cd02b38.
The test was successful.

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== PAUSE TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== CONT  TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
--- PASS: TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes (2677.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/network	2679.478s

[stephybun]

Thanks @aeimer, a few things need to be fixed up, but once that's done I can run the tests and see if this ready to be merged.

[aeimer]

Re-ran tests on b61f36a.
Test was successful.

>>>> Starting tests
2025-03-26T14:02:18Z
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes -timeout 90m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== PAUSE TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== CONT  TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
--- PASS: TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes (2479.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/network	2482.112s

real	43m55.001s
user	10m41.101s
sys	2m18.043s
>>>> Tests completed

[stephybun]

ImportStep went missing in the last update, once that's added this should be good to go

[aeimer]

Re-ran tests on e245e41.
Test was successful.

>>>> Starting tests
2025-03-27T10:05:47Z
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes -timeout 90m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== PAUSE TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
=== CONT  TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes
--- PASS: TestAccVirtualHubConnection_routeMapAndStaticVnetPropagateStaticRoutes (2778.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/network	2780.773s

[stephybun]

Thanks @aeimer LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.