parsing virtual_machine os disk response case-insensitively#28592
Merged
stephybun merged 1 commit intohashicorp:mainfrom Jan 27, 2025
Merged
parsing virtual_machine os disk response case-insensitively#28592stephybun merged 1 commit intohashicorp:mainfrom
stephybun merged 1 commit intohashicorp:mainfrom
Conversation
stephybun
approved these changes
Jan 27, 2025
Member
stephybun
left a comment
There was a problem hiding this comment.
Thanks @joshd-emergent LGTM 👍
stephybun
added a commit
that referenced
this pull request
Jan 27, 2025
jackofallops
added a commit
that referenced
this pull request
Jan 31, 2025
* Update for #27950 * Update for #27824 * Update for #28592 #28583 #28599 #28590 #28453 * Update #28528 * Update for #27853 * Update CHANGELOG.md #28221 * Update for #27760 * Update CHANGELOG.md #28480 * Update CHANGELOG.md typo * Update CHANGELOG.md #28372 * Update CHANGELOG.md for #26047 also alphabetised ENHANCEMENTS * Update for #28146 * Update CHANGELOG.md #28013 * Update CHANGELOG.md for #28492 * Update CHANGELOG.md for #28648 * Update CHANGELOG.md for #28549 * Update for #28469 #28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
hqhqhqhqhqhqhqhqhqhqhq
pushed a commit
to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm
that referenced
this pull request
Feb 26, 2025
* Update for hashicorp#27950 * Update for hashicorp#27824 * Update for hashicorp#28592 hashicorp#28583 hashicorp#28599 hashicorp#28590 hashicorp#28453 * Update hashicorp#28528 * Update for hashicorp#27853 * Update CHANGELOG.md hashicorp#28221 * Update for hashicorp#27760 * Update CHANGELOG.md hashicorp#28480 * Update CHANGELOG.md typo * Update CHANGELOG.md hashicorp#28372 * Update CHANGELOG.md for hashicorp#26047 also alphabetised ENHANCEMENTS * Update for hashicorp#28146 * Update CHANGELOG.md hashicorp#28013 * Update CHANGELOG.md for hashicorp#28492 * Update CHANGELOG.md for hashicorp#28648 * Update CHANGELOG.md for hashicorp#28549 * Update for hashicorp#28469 hashicorp#28620 * prep for release * i touched it last --------- Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Azure resource IDs aren’t strictly case-sensitive, they can fail to parse if the parser enforces exact casing. To ensure valid IDs aren’t rejected, parse them case-insensitively.
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #28591
Note
If this PR changes meaningfully during the course of review please update the title and description as required.