Conversation
… values and the state doesn't have it set
1fa019e to
0a04338
Compare
azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - site_config.0.cors is now Optional/Computed to fix a perpetual diffazurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Changes are ignored when site_config.0.cors wants to update to the default values and the state doesn't have it set
jackofallops
approved these changes
Feb 10, 2025
Member
jackofallops
left a comment
There was a problem hiding this comment.
Thanks @mbfrahry - LGTM 👍
azurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Changes are ignored when site_config.0.cors wants to update to the default values and the state doesn't have it setazurerm_windows_web_app, azurerm_linux_web_app, azurerm_windows_function_app, azurerm_linux_function_app - Terraform will no longer plan when site_config.0.cors are the default values
mbfrahry
added a commit
that referenced
this pull request
Feb 10, 2025
jackofallops
added a commit
that referenced
this pull request
Feb 14, 2025
* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md #28523 * Update CHANGELOG.md #28691 * Updated to include #28717 * Update for #26680 * Update CHANGELOG.md #28633 * Update CHANGELOG.md for #28703 * Update CHANGELOG.md for #28391 * Update CHANGELOG.md #28725 * Update #28733 * Update CHANGELOG.md #28659 * Update for #28741 * Update CHANGELOG.md #28712 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md for #28602 * Update for #27424 * Update CHANGELOG.md for #28524 * Update CHANGELOG.md #28726 * Update for #28767 * Update for #28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
hqhqhqhqhqhqhqhqhqhqhq
pushed a commit
to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm
that referenced
this pull request
Feb 26, 2025
…function_app`, `azurerm_linux_function_app` - Terraform will no longer plan when `site_config.0.cors` are the default values(hashicorp#28703)
hqhqhqhqhqhqhqhqhqhqhq
pushed a commit
to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm
that referenced
this pull request
Feb 26, 2025
* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md hashicorp#28523 * Update CHANGELOG.md hashicorp#28691 * Updated to include hashicorp#28717 * Update for hashicorp#26680 * Update CHANGELOG.md hashicorp#28633 * Update CHANGELOG.md for hashicorp#28703 * Update CHANGELOG.md for hashicorp#28391 * Update CHANGELOG.md hashicorp#28725 * Update hashicorp#28733 * Update CHANGELOG.md hashicorp#28659 * Update for hashicorp#28741 * Update CHANGELOG.md hashicorp#28712 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md for hashicorp#28602 * Update for hashicorp#27424 * Update CHANGELOG.md for hashicorp#28524 * Update CHANGELOG.md hashicorp#28726 * Update for hashicorp#28767 * Update for hashicorp#28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
There was a perpetual diff caused by
corsthat can only be fixed by setting that field as Optional/ComputedPR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_windows_web_app,azurerm_linux_web_app,azurerm_windows_function_app,azurerm_linux_function_app-site_config.0.corsis now Optional/Computed to fix a perpetual diff [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #22879
Note
If this PR changes meaningfully during the course of review please update the title and description as required.