Update desktopvirtualization API to `2024-04-03` by sinbai · Pull Request #28771 · hashicorp/terraform-provider-azurerm

sinbai · 2025-02-14T07:35:56Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Update desktopvirtualization API to 2024-04-03.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

desktopvirtualization - update api to 2024-04-03

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

sreallymatt

Thanks for this PR @sinbai, I've left a few comments inline if you wouldn't mind taking a look!

sreallymatt · 2025-02-25T23:55:22Z

internal/services/desktopvirtualization/virtual_desktop_application_group_data_source.go

 			state.ApplicationGroupName = id.ApplicationGroupName
 			state.ResourceGroupName = id.ResourceGroupName
-			state.Location = location.NormalizeNilable(model.Location)
+			state.Location = location.NormalizeNilable(&model.Location)


Suggested change

state.Location = location.NormalizeNilable(&model.Location)

state.Location = location.Normalize(model.Location)

sreallymatt · 2025-02-25T23:55:31Z

internal/services/desktopvirtualization/virtual_desktop_application_group_resource.go


 	if model := resp.Model; model != nil {
-		d.Set("location", location.NormalizeNilable(model.Location))
+		d.Set("location", location.NormalizeNilable(&model.Location))


Suggested change

d.Set("location", location.NormalizeNilable(&model.Location))

d.Set("location", location.Normalize(model.Location))

sreallymatt · 2025-02-25T23:55:37Z

internal/services/desktopvirtualization/virtual_desktop_host_pool_data_source.go


 	if model := resp.Model; model != nil {
-		d.Set("location", location.NormalizeNilable(model.Location))
+		d.Set("location", location.NormalizeNilable(&model.Location))


Suggested change

d.Set("location", location.NormalizeNilable(&model.Location))

d.Set("location", location.Normalize(model.Location))

sreallymatt · 2025-02-25T23:55:46Z

internal/services/desktopvirtualization/virtual_desktop_host_pool_resource.go


 	if model := resp.Model; model != nil {
-		d.Set("location", location.NormalizeNilable(model.Location))
+		d.Set("location", location.NormalizeNilable(&model.Location))


Suggested change

d.Set("location", location.NormalizeNilable(&model.Location))

d.Set("location", location.Normalize(model.Location))

sreallymatt · 2025-02-25T23:56:04Z

...ervices/desktopvirtualization/virtual_desktop_scaling_plan_host_pool_association_resource.go


 	hostPoolStr := hostPoolId.ID()
-	if scalingPlanHostPoolAssociationExists(model.Properties, hostPoolStr) {
+	if scalingPlanHostPoolAssociationExists(&model.Properties, hostPoolStr) {


Could we update scalingPlanHostPoolAssociationExists to accept a value rather than a pointer instead of passing the address here?

sreallymatt · 2025-02-25T23:56:07Z

...ervices/desktopvirtualization/virtual_desktop_scaling_plan_host_pool_association_resource.go

 	if model := scalingPlan.Model; model != nil {
 		hostPoolId := id.HostPool.ID()
-		exists := scalingPlanHostPoolAssociationExists(model.Properties, hostPoolId)
+		exists := scalingPlanHostPoolAssociationExists(&model.Properties, hostPoolId)


Same comment as above regarding updating scalingPlanHostPoolAssociationExists

sreallymatt · 2025-02-25T23:56:10Z

...ervices/desktopvirtualization/virtual_desktop_scaling_plan_host_pool_association_resource.go

 	}
 	model := *existing.Model
-	if !scalingPlanHostPoolAssociationExists(model.Properties, id.HostPool.ID()) {
+	if !scalingPlanHostPoolAssociationExists(&model.Properties, id.HostPool.ID()) {


Same comment as above regarding updating scalingPlanHostPoolAssociationExists

sreallymatt · 2025-02-25T23:56:32Z

internal/services/desktopvirtualization/virtual_desktop_scaling_plan_resource.go

-			d.Set("schedule", flattenScalingPlanSchedule(props.Schedules))
-			d.Set("host_pool", flattenScalingHostpoolReference(props.HostPoolReferences))
-		}
+		d.Set("location", location.NormalizeNilable(&model.Location))


Suggested change

d.Set("location", location.NormalizeNilable(&model.Location))

d.Set("location", location.Normalize(model.Location))

sreallymatt · 2025-02-25T23:56:41Z

internal/services/desktopvirtualization/virtual_desktop_workspace_data_source.go

 			}

-			state.Location = location.NormalizeNilable(model.Location)
+			state.Location = location.NormalizeNilable(&model.Location)


Suggested change

state.Location = location.NormalizeNilable(&model.Location)

state.Location = location.Normalize(model.Location)

sreallymatt · 2025-02-25T23:56:51Z

internal/services/desktopvirtualization/virtual_desktop_workspace_resource.go


 	if model := resp.Model; model != nil {
-		d.Set("location", location.NormalizeNilable(model.Location))
+		d.Set("location", location.NormalizeNilable(&model.Location))


Suggested change

d.Set("location", location.NormalizeNilable(&model.Location))

d.Set("location", location.Normalize(model.Location))

sinbai · 2025-02-26T03:32:37Z

Thanks for this PR @sinbai, I've left a few comments inline if you wouldn't mind taking a look!

Hi @sreallymatt thanks for your detailed feedback. I have updated the code. Could you please take another look?

sreallymatt

Thanks @sinbai, LGTM!

* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com>

github-actions · 2025-03-29T02:15:58Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

sinbai added 2 commits February 14, 2025 10:09

upgrade api version to 20240403

891afa7

update code

68a78f5

github-actions bot added dependencies service/virtual-desktops state-migration size/XL waiting-response labels Feb 14, 2025

update code

31c53f3

github-actions bot removed the waiting-response label Feb 14, 2025

sinbai changed the title ~~Upgrade desktopvirtualization API to 2024-04-03~~ Update desktopvirtualization API to 2024-04-03 Feb 14, 2025

github-actions bot added the enhancement label Feb 14, 2025

sinbai marked this pull request as ready for review February 14, 2025 08:58

sinbai requested a review from a team as a code owner February 14, 2025 08:58

sreallymatt requested changes Feb 25, 2025

View reviewed changes

github-actions bot assigned sreallymatt Feb 25, 2025

github-actions bot added the waiting-response label Feb 25, 2025

fix comments

0f1b09a

github-actions bot removed the waiting-response label Feb 26, 2025

stephybun mentioned this pull request Feb 26, 2025

Use supported DesktopVirtualization API version #28885

Closed

14 tasks

sreallymatt approved these changes Feb 26, 2025

View reviewed changes

sreallymatt merged commit 928a53d into hashicorp:main Feb 26, 2025
30 checks passed

github-actions bot added this to the v4.21.0 milestone Feb 26, 2025

sreallymatt added a commit that referenced this pull request Feb 26, 2025

Update CHANGELOG.md #28771

c145a26

github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2025

	state.Location = location.NormalizeNilable(&model.Location)
	state.Location = location.Normalize(model.Location)

	d.Set("location", location.NormalizeNilable(&model.Location))
	d.Set("location", location.Normalize(model.Location))

Conversation

sinbai commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Testing

Change Log

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sreallymatt Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sreallymatt Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sinbai commented Feb 26, 2025

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sinbai commented Feb 14, 2025 •

edited

Loading

sreallymatt Feb 25, 2025 •

edited

Loading

sreallymatt Feb 25, 2025 •

edited

Loading