azurerm_container_app: add support for client_certificate_mode in data source#28793
Merged
sreallymatt merged 2 commits intohashicorp:mainfrom Feb 20, 2025
Merged
Conversation
Closed
1 task
sreallymatt
requested changes
Feb 19, 2025
Collaborator
sreallymatt
left a comment
There was a problem hiding this comment.
Thanks for fixing this @jiaweitao001, I've left one comment inline
|
|
||
| * `transport` - The transport method for the Ingress. Possible values include `auto`, `http`, and `http2`. Defaults to `auto` | ||
|
|
||
| * `client_certificate_mode` - The client certificate mode for the Ingress. |
Collaborator
There was a problem hiding this comment.
Could you move this property above custom_domain so it's in alphabetical order?
Collaborator
Author
There was a problem hiding this comment.
Sure. Will fix.
sreallymatt
added a commit
that referenced
this pull request
Feb 20, 2025
hqhqhqhqhqhqhqhqhqhqhq
pushed a commit
to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm
that referenced
this pull request
Feb 26, 2025
… data source (hashicorp#28793) * azurerm_container_app: add support for client_certificate_mode in data source * address comments on docs
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_container_app: add support forclient_certificate_modein data sourceThis is a (please select all that apply):
Related Issue(s)
Fixes #28800
Related to #28523
Note
If this PR changes meaningfully during the course of review please update the title and description as required.