`azurerm_mssql_server` - add support for `administrator_login_password_wo` and `administrator_login_password_wo_version` by mbfrahry · Pull Request #28818 · hashicorp/terraform-provider-azurerm

mbfrahry · 2025-02-19T23:57:03Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds support for the write only attribute administrator_login_password_wo.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_mssql_server - add support for administrator_login_password_wo and administrator_login_password_wo_version [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

stephybun

Thanks @mbfrahry! Could you take a look at the comment left in-line about the tests? Once that's resolved this should be good to go!

stephybun · 2025-02-24T07:51:38Z

internal/services/mssql/mssql_server_resource_test.go

+func TestAccMsSqlServer_writeOnlyAdminLoginPassword(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_mssql_server", "test")
+	r := MsSqlServerResource{}
+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.writeOnlyAdminLoginPassword(data, "7h1515K4711-secret", 1),
+			Check:  check.That(data.ResourceName).ExistsInAzure(r),
+		},
+		data.ImportStep("administrator_login_password_wo_version"),
+		{
+			Config: r.writeOnlyAdminLoginPassword(data, "7h1515K4711-updated", 2),
+			Check:  check.That(data.ResourceName).ExistsInAzure(r),
+		},
+		data.ImportStep("administrator_login_password_wo_version"),
+	})
+}
+
+func TestAccMsSqlServer_updateToWriteOnlyPassword(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_mssql_server", "test")
+	r := MsSqlServerResource{}
+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.basic(data),
+			Check:  check.That(data.ResourceName).ExistsInAzure(r),
+		},
+		data.ImportStep("administrator_login_password"),
+		{
+			Config: r.writeOnlyAdminLoginPassword(data, "7h1515K4711-secret", 1),
+			Check:  check.That(data.ResourceName).ExistsInAzure(r),
+		},
+		data.ImportStep("administrator_login_password", "administrator_login_password_wo_version"),
+		{
+			Config: r.basic(data),
+			Check:  check.That(data.ResourceName).ExistsInAzure(r),
+		},
+		data.ImportStep("administrator_login_password"),
+	})
+}


These tests need to be skipped for Terraform versions < 1.11. There's an example in the preliminary guide I shared on how to do that, or you can take a look at the tests over in my PR.

Oh shoot! Swapped! Thank you thank you

stephybun

Thanks @mbfrahry, one last comment on the docs but otherwise this should be good to go!

stephybun · 2025-02-25T14:29:26Z

website/docs/r/mssql_server.html.markdown

+* `administrator_login_password` - (Optional) The password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx). Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.
+
+* `administrator_login_password_wo` - (Optional, Write-Only) The Password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx). Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.


Matt suggested adding a note instead of duplicating the either x or y is required information on the property descriptions on my PRs which I've updated. Can you make that change here as well so it's consistent?

Suggested change

* `administrator_login_password` - (Optional) The password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx). Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.

* `administrator_login_password_wo` - (Optional, Write-Only) The Password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx). Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.

* `administrator_login_password` - (Optional) The password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx).

* `administrator_login_password_wo` - (Optional, Write-Only) The Password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx).

~> **Note:** Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.

sreallymatt

LGTM! 😎

* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com>

github-actions · 2025-03-28T02:17:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

azurerm_mssql_server - add support for administrator_login_password_wo

bd9ea46

mbfrahry requested a review from a team as a code owner February 19, 2025 23:57

github-actions bot added enhancement documentation service/mssql Microsoft SQL Server size/L waiting-response and removed enhancement labels Feb 19, 2025

stephybun reviewed Feb 24, 2025

View reviewed changes

stephybun added the write-only label Feb 24, 2025

address review

b710194

github-actions bot removed the waiting-response label Feb 24, 2025

stephybun reviewed Feb 25, 2025

View reviewed changes

github-actions bot added the waiting-response label Feb 25, 2025

Address review

26a4fbe

github-actions bot removed the waiting-response label Feb 25, 2025

sreallymatt approved these changes Feb 25, 2025

View reviewed changes

mbfrahry added this to the v4.21.0 milestone Feb 25, 2025

mbfrahry merged commit 578c0f4 into main Feb 25, 2025
33 checks passed

mbfrahry deleted the mssql-server-wo-password branch February 25, 2025 23:01

mbfrahry added a commit that referenced this pull request Feb 25, 2025

Update CHANGELOG.md for #28818

ba32b08

github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_mssql_server` - add support for `administrator_login_password_wo` and `administrator_login_password_wo_version`#28818

`azurerm_mssql_server` - add support for `administrator_login_password_wo` and `administrator_login_password_wo_version`#28818
mbfrahry merged 3 commits intomainfrom
mssql-server-wo-password

mbfrahry commented Feb 19, 2025

Uh oh!

stephybun left a comment

Uh oh!

stephybun Feb 24, 2025

Uh oh!

mbfrahry Feb 24, 2025

Uh oh!

stephybun left a comment

Uh oh!

stephybun Feb 25, 2025

Uh oh!

sreallymatt left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		* `administrator_login_password` - (Optional) The password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx). Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.

		* `administrator_login_password_wo` - (Optional, Write-Only) The Password associated with the `administrator_login` user. Needs to comply with Azure's [Password Policy](https://msdn.microsoft.com/library/ms161959.aspx). Either `administrator_login_password` or `administrator_login_password_wo` is required unless `azuread_authentication_only` in the `azuread_administrator` block is `true`.

Conversation

mbfrahry commented Feb 19, 2025

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

stephybun Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

mbfrahry Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

stephybun Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants