Upgrade `Workloads` API version from `2023-04-01` to `2024-09-01` by neil-yechenwei · Pull Request #28825 · hashicorp/terraform-provider-azurerm

neil-yechenwei · 2025-02-20T09:55:15Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Service team asks us to support new feature on new API version 2024-09-01. So I need to upgrade API version first.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/basic (1133.72s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/requiresImport (1043.39s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/complete (1015.58s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/update (2232.53s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_basic (2217.08s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_requiresImport (2222.53s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_complete (2213.37s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_update (2403.54s)
--- PASS: TestAccWorkloadsSAPThreeTierVirtualInstance_basic (3051.08s)
--- PASS: TestAccWorkloadsSAPThreeTierVirtualInstance_requiresImport (2942.76s)
--- PASS: TestAccWorkloadsSAPThreeTierVirtualInstance_complete (2999.09s)
--- PASS: TestAccWorkloadsSAPThreeTierVirtualInstance_update (3468.19s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

Upgrade Workloads API version from 2023-04-01 to 2024-09-01

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

stephybun · 2025-02-25T08:12:31Z

internal/services/workloads/workloads_sap_discovery_virtual_instance_resource.go

 				state.Identity = pointer.From(identity)

-				props := &model.Properties
+				props := model.Properties


Since this is now a pointer we should be nil checking this like we do in other resources:

Suggested change

props := model.Properties

if props := model.Properties; props != nil {

// set things into state here

}

stephybun · 2025-02-25T08:12:40Z

internal/services/workloads/workloads_sap_single_node_virtual_instance_resource.go

 				state.Identity = pointer.From(identity)

-				props := &model.Properties
+				props := model.Properties


Likewise here

stephybun · 2025-02-25T08:12:50Z

internal/services/workloads/workloads_sap_three_tier_virtual_instance_resource.go

 				state.Identity = pointer.From(identity)

-				props := &model.Properties
+				props := model.Properties


stephybun

Thanks @neil-yechenwei LGTM 👍

* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com>

github-actions · 2025-03-28T02:17:37Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 3 commits February 14, 2025 15:16

Upgrade Workloads API version from 2023-04-01 to 2024-09-01

1067901

update test case

fafc286

use updateThenPoll

845a1c4

neil-yechenwei requested a review from a team as a code owner February 20, 2025 09:55

github-actions bot added dependencies service/workloads size/XL enhancement labels Feb 20, 2025

stephybun suggested changes Feb 25, 2025

View reviewed changes

github-actions bot assigned stephybun Feb 25, 2025

github-actions bot added the waiting-response label Feb 25, 2025

Add nil checking for model.Properties

9988be7

github-actions bot removed the waiting-response label Feb 25, 2025

stephybun reviewed Feb 25, 2025

View reviewed changes

stephybun approved these changes Feb 25, 2025

View reviewed changes

stephybun merged commit dbfd14f into hashicorp:main Feb 25, 2025
34 checks passed

github-actions bot added this to the v4.21.0 milestone Feb 25, 2025

stephybun added a commit that referenced this pull request Feb 25, 2025

Update for #28825

b87e302

github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade `Workloads` API version from `2023-04-01` to `2024-09-01`#28825

Upgrade `Workloads` API version from `2023-04-01` to `2024-09-01`#28825
stephybun merged 4 commits intohashicorp:mainfrom
neil-yechenwei:upgradeworkloadstonewapiv20240901

neil-yechenwei commented Feb 20, 2025 •

edited

Loading

Uh oh!

stephybun Feb 25, 2025

Uh oh!

neil-yechenwei Feb 25, 2025

Uh oh!

stephybun Feb 25, 2025

Uh oh!

neil-yechenwei Feb 25, 2025

Uh oh!

stephybun Feb 25, 2025

Uh oh!

neil-yechenwei Feb 25, 2025

Uh oh!

stephybun left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-				props := model.Properties
+				if props := model.Properties; props != nil {
+					// set things into state here
+				}

Conversation

neil-yechenwei commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Uh oh!

stephybun Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

stephybun Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

stephybun Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

neil-yechenwei commented Feb 20, 2025 •

edited

Loading