azurerm_[linux|windows]_function_app[_slot] - correctly update WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING when changed in app_settings#28859
Merged
jackofallops merged 1 commit intomainfrom Feb 25, 2025
Conversation
…ENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING on update
Member
Author
|
Testing looking fine, few transient failures not related to changes:
|
catriona-m
approved these changes
Feb 25, 2025
Member
catriona-m
left a comment
catriona-m
left a comment
There was a problem hiding this comment.
Thanks @jackofallops LGTM!
jackofallops
added a commit
that referenced
this pull request
Feb 25, 2025
jackofallops
added a commit
that referenced
this pull request
Feb 27, 2025
* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
|
My apologies in case this is the wrong place to ask, but are there any plans to also roll out this fix for the resource type 'azurerm_logic_app_standard'? currently it seems that Terraform will still overwrite the value for 'WEBSITE_CONTENTSHARE' that is set in app_settings. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
fixes a bug where existing values are used in place of any user specified value for
WEBSITE_CONTENTSHAREandWEBSITE_CONTENTAZUREFILECONNECTIONSTRINGinapp_settingsazurerm_linux_function_app- correctly updateWEBSITE_CONTENTSHAREandWEBSITE_CONTENTAZUREFILECONNECTIONSTRINGwhen changed inapp_settings.azurerm_linux_function_app_slot- correctly updateWEBSITE_CONTENTSHAREandWEBSITE_CONTENTAZUREFILECONNECTIONSTRINGwhen changed inapp_settings.azurerm_windows_function_app- correctly updateWEBSITE_CONTENTSHAREandWEBSITE_CONTENTAZUREFILECONNECTIONSTRINGwhen changed inapp_settings.azurerm_windows_function_app_slot- correctly updateWEBSITE_CONTENTSHAREandWEBSITE_CONTENTAZUREFILECONNECTIONSTRINGwhen changed inapp_settings.This is a (please select all that apply):
Related Issue(s)
Fixes #28434
supersedes #28521
Note
If this PR changes meaningfully during the course of review please update the title and description as required.