Skip to content

azurerm_cognitive_deployment - Support DataZoneBatch in sku.name#28973

Merged
catriona-m merged 1 commit intohashicorp:mainfrom
liuwuliuyun:fix-28666
Mar 12, 2025
Merged

azurerm_cognitive_deployment - Support DataZoneBatch in sku.name#28973
catriona-m merged 1 commit intohashicorp:mainfrom
liuwuliuyun:fix-28666

Conversation

@liuwuliuyun
Copy link
Collaborator

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

azurerm_cognitive_deployment - Add DataZoneBatch to supported sku

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_cognitive_deployment - Support DataZoneBatch in sku.name [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28666

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun - just checking if you have done any testing to confirm that you can create an azurerm_cognititive_deployment with DataZoneBatch sku successfully?

@liuwuliuyun
Copy link
Collaborator Author

@catriona-m sure, I tested with following template locally
image
with changed setting in
image
and have test passed.
image

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming @liuwuliuyun - LGTM!

@catriona-m catriona-m merged commit 8c97066 into hashicorp:main Mar 12, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.23.0 milestone Mar 12, 2025
catriona-m added a commit that referenced this pull request Mar 12, 2025
@liuwuliuyun liuwuliuyun deleted the fix-28666 branch March 20, 2025 01:51
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for new types of Azure OpenAI DataZoneBatch & DataZoneStandard deployments

2 participants