Skip to content

azurerm_postgresql_flexible_server - update validation for CMKs, versionless keys are not supported#28981

Merged
sreallymatt merged 1 commit intomainfrom
mp/prevent-versionless-ids
Mar 7, 2025
Merged

azurerm_postgresql_flexible_server - update validation for CMKs, versionless keys are not supported#28981
sreallymatt merged 1 commit intomainfrom
mp/prevent-versionless-ids

Conversation

@sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Mar 6, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Passing a versionless key ID causes the deployment to fail with an unhelpful InternalServerError error message. When provisioning a postgresql flexible server resource in Azure portal the CMK ID field's validation states a version guid is required.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Failed test was in post test destroy, failed to remove a subnet, unrelated to changes

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_postgresql_flexible_server - fix customer_managed_key.key_vault_key_id and customer_managed_key.geo_backup_key_vault_key_id validation to prevent unclear error messages [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreallymatt sreallymatt merged commit 9c373ba into main Mar 7, 2025
34 checks passed
@sreallymatt sreallymatt deleted the mp/prevent-versionless-ids branch March 7, 2025 14:16
@github-actions github-actions bot added this to the v4.23.0 milestone Mar 7, 2025
sreallymatt added a commit that referenced this pull request Mar 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants