azurerm_postgresql_flexible_server_configuration: should lock the replica server

[wuxu92]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

A locker to the replica server is also required when add a virutal endpoint. there is a internal ticket about updating configuration and creating virtual endpoint in parallel which caused an issue:

Then, it was followed by a configuration update (UpdateConfigurationManagementOperation).
And then it got the restart server request (RestartServerManagementOperation), which succeeded normally, however, it is right there when the create virtual endpoint requests were triggered, right in the middle of the server restart.

In mean time, the locker to the configuraiton name is not required while we already had a locker on the server itself.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_postgresql_flexible_server_configuration - add locker to the replication server id

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

These were added recently in #27355 and seem to have fixed an issue so I don't think we should be removing them

[wuxu92]

This lock is meaningless here and does not actually resolve the issue it was intended to. The issue still exists and needs further investigation. and there is already a lock to the flexible server above: locks.ByName(id.FlexibleServerName, postgresqlFlexibleServerResourceName).

[stephybun]

Could you resolve the merge conflicts so this can be merged?

[stephybun]

Thanks @wuxu92 LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.