azurerm_windows_web_app/azurerm_windows_web_app_slot - fix perpetual diff around incorrect default for always_on and ignore default values for logs.0.application_logs

[mbfrahry]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR fixes an issue where a perpetual diff occurred when always_on was false. Azure changed the default value of virtual_application.0.preload_enabled to false whereas we assumed it was true regardless of always_on.

This PR also addresses an issue where we were not setting logs.0.application_logs.0.file_system_level was Off. This was added to prevent a perpetual diff when the default values for logs.0.application_logs were returned by Azure but not set into Terraform which resulted in a perpetual diff. We now only set logs.0.application_logs when it's not the default values and use a DiffSuppressFunc to ignore the default values on subsequent plans.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_windows_web_app/azurerm_windows_web_app_slot - fix perpetual diff around incorrect default for always_on and ignore default values for logs.0.application_logs [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #16326

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[mbfrahry]

Failing tests were transient

[sreallymatt]

@mbfrahry I left one minor comment inline

[sreallymatt]

I believe this should be false?

Suggested change

	always_on = true
	always_on = false

[mbfrahry]

Taken care of. ty ty

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[sreallymatt]

LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.