azurerm_log_analytics_workspace_table - reset retention_in_days when it's not specified

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

When retention_in_days is not specified, we need to pass -1 in payload, 0 is not a valid value for the service.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

❯ tftest loganalytics TestAccLogAnalyticsWorkspaceTable_
=== RUN   TestAccLogAnalyticsWorkspaceTable_updateTableRetention
=== PAUSE TestAccLogAnalyticsWorkspaceTable_updateTableRetention
=== RUN   TestAccLogAnalyticsWorkspaceTable_plan
=== PAUSE TestAccLogAnalyticsWorkspaceTable_plan
=== CONT  TestAccLogAnalyticsWorkspaceTable_updateTableRetention
=== CONT  TestAccLogAnalyticsWorkspaceTable_plan
--- PASS: TestAccLogAnalyticsWorkspaceTable_plan (140.33s)
--- PASS: TestAccLogAnalyticsWorkspaceTable_updateTableRetention (165.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics  165.381s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_log_analytics_workspace_table - reset retention_in_days when it's not specified [azurerm_log_analytics_workspace_table - reset retention_in_days when it's not specified #29182]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #29163

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[kevinbasoftcat]

Any update on when this PR can be reviewed and merged so we can utilise the fix.

[kevinbasoftcat]

@ziyeqf are you able to get any update on when this will be reviewed?

[niven01]

Any idea on when this will be released?

[kevinbasoftcat]

@katbyte @mbfrahry @jackofallops would anyone be able to review this please as currently unable to use this resource due to the fact the optional argument isn't actually optional and unable to set to the correct -1 value if setting the argument value manually.

[catriona-m]

HI @ziyeqf thanks for submitting this. I wanted to check if there is a default value we can set for this property that we should use here? Thanks!

[ziyeqf]

@catriona-m this resource does not create tables, but to change the retention_in_days of existing tables. for tables, when it's not specified, the value inherit from azurerm_log_analytics_workspace. I don't think we can set a default value for it.

[catriona-m]

Thanks for clarifying @ziyeqf - LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.