Skip to content

Add optional argument to oracle_autonomous_database, fix issue with backup_retention_period_in_days, and mark system_version as computed in VmClusterResource#29207

Merged
jackofallops merged 48 commits intohashicorp:mainfrom
mihretkidane-OCI:fix-issue-with-backUpretentionPeriod/LongtermBackupSchedule
Jun 27, 2025
Merged

Add optional argument to oracle_autonomous_database, fix issue with backup_retention_period_in_days, and mark system_version as computed in VmClusterResource#29207
jackofallops merged 48 commits intohashicorp:mainfrom
mihretkidane-OCI:fix-issue-with-backUpretentionPeriod/LongtermBackupSchedule

Conversation

@mihretkidane-OCI
Copy link
Contributor

@mihretkidane-OCI mihretkidane-OCI commented Mar 27, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

New Optional Argument:

long_term_backup_schedule: Allows users to configure automated long-term backup schedules for their Autonomous Database. Supported options include weekly, monthly, yearly, or a one-time backup.

Updated Arguments:

backup_retention_period_in_days: Removed the ForceNew property since this field is now updatable without requiring resource recreation.

system_version: Marked as Computed: true in the cloud_vm_cluster_resource, as the system automatically sets a default value when none is provided by the user during creation. We have the same behavior in cloud_vm_cluster_dataSource.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Screenshot 2025-03-31 at 3 38 16 PM
Screenshot 2025-03-31 at 2 17 40 PM

Screenshot 2025-04-04 at 12 15 57 PM
Screenshot 2025-04-04 at 9 41 21 AM

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #29232

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

and made BackupRetentionPeriodInDays updatable
# Conflicts:
#	website/docs/r/oracle_cloud_vm_cluster.html.markdown
…riod/LongtermBackupSchedule' into fix-issue-with-backUpretentionPeriod/LongtermBackupSchedule
@mihretkidane-OCI
Copy link
Contributor Author

Screenshot 2025-06-17 at 12 24 21 PM

test result after applying latest changes.

@mihretkidane-OCI
Copy link
Contributor Author

@sreallymatt resolved all comments please help review PR. Thank you!

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
mihretkidane-OCI and others added 2 commits June 25, 2025 10:37
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mihretkidane-OCI LGTM ✅

@jackofallops jackofallops merged commit 3bbe068 into hashicorp:main Jun 27, 2025
33 checks passed
@github-actions github-actions bot added this to the v4.35.0 milestone Jun 27, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for long_term_backup_schedule for Oracle autonomous database

5 participants