Skip to content

azurerm_netapp_volume - service_level can now be updated#29209

Merged
mbfrahry merged 3 commits intomainfrom
e-netapp-volume-service-level
Apr 3, 2025
Merged

azurerm_netapp_volume - service_level can now be updated#29209
mbfrahry merged 3 commits intomainfrom
e-netapp-volume-service-level

Conversation

@mbfrahry
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds support to update service_level.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_netapp_volume - service_level can now be updated [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #12102

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry, I've left a couple comments inline

@mbfrahry
Copy link
Member Author

mbfrahry commented Apr 1, 2025

All test failures are transient and the new test added passes
image

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulomarquesc
Copy link
Contributor

Hi @mbfrahry , this looks good to me, thanks for looping me in into this PR.

@mbfrahry mbfrahry added this to the v4.26.0 milestone Apr 3, 2025
@mbfrahry mbfrahry merged commit 981368e into main Apr 3, 2025
33 checks passed
@mbfrahry mbfrahry deleted the e-netapp-volume-service-level branch April 3, 2025 21:12
mbfrahry added a commit that referenced this pull request Apr 3, 2025
jackofallops added a commit that referenced this pull request Apr 4, 2025
* new changelog for 4.26.0

* Update CHANGELOG.md #29212

* Update CHANGELOG.md #28786

* Update CHANGELOG.md for #29095

* Update CHANGELOG.md #29225

* Update CHANGELOG.md #29168

* Update CHANGELOG.md #28890

* Update CHANGELOG.md for #28689

* Update CHANGELOG.md #28354

* Update CHANGELOG.md #29240

* Update CHANGELOG.md for #29211

* Update CHANGELOG.md #29214

* Update CHANGELOG.md for #29209

* Update CHANGELOG.md for 28690

* Update CHANGELOG.md for #28577

* Update for #29217 #29144 #29145

* Update CHANGELOG.md for #29185

* prep for release

---------

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
Co-authored-by: Wyatt Fry <wyattfry@gmail.com>
Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: stephybun <steph@hashicorp.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for [Azure NetApp Files - Dynamic Service Level Change ]

3 participants